You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/15 17:26:24 UTC
[GitHub] [superset] prosdev0107 opened a new pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
prosdev0107 opened a new pull request #19159:
URL: https://github.com/apache/superset/pull/19159
### SUMMARY
d3 format selection widgets should use case sensitive matching for determining uniqueness #17716
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
### TESTING INSTRUCTIONS
**How to reproduce the bug**
1. Go to 'explore'
2. Create a new 'Time-series Line Chart' (or similar)
3. Click on the 'CUSTOMIZE' tab
4. Try entering the '%b %Y' d3 format for the X-Axis TIME FORMAT (or some other format which matches in a case insensitive way)
5. See that the UI component senses this is a match with '%B %Y' even though these are different
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19159:
URL: https://github.com/apache/superset/pull/19159#issuecomment-1070594415
# [Codecov](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19159](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6a3966) into [master](https://codecov.io/gh/apache/superset/commit/cfb967f430a75d363693d79494239b1686fd6e5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cfb967f) will **decrease** coverage by `0.00%`.
> The diff coverage is `28.57%`.
```diff
@@ Coverage Diff @@
## master #19159 +/- ##
==========================================
- Coverage 66.73% 66.73% -0.01%
==========================================
Files 1668 1668
Lines 64271 64273 +2
Branches 6496 6498 +2
==========================================
Hits 42894 42894
- Misses 19695 19697 +2
Partials 1682 1682
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.31% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <28.57%> (-0.75%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cfb967f...c6a3966](https://codecov.io/gh/apache/superset/pull/19159?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #19159:
URL: https://github.com/apache/superset/pull/19159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prosdev0107 commented on pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
prosdev0107 commented on pull request #19159:
URL: https://github.com/apache/superset/pull/19159#issuecomment-1068424938
@ktmud
I passed the filterOption instead of any new option. Resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #19159:
URL: https://github.com/apache/superset/pull/19159#issuecomment-1068267066
Instead of adding yet another config option, how about just passing `filterOption` as a function?
```suggestion
filterOption: (search, option) => option.label.includes(search) || option.value.includes(search)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #19159:
URL: https://github.com/apache/superset/pull/19159#issuecomment-1068267066
Instead of adding yet another config option, how about just passing `filterOption` as a function?
```suggestion
filterOption: (search, option) => option.label.includes(search)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #19159: fix(select): make to consider the case sensitive in case of d3 format selector
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #19159:
URL: https://github.com/apache/superset/pull/19159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org