You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2008/11/21 02:16:46 UTC
[jira] Created: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
--------------------------------------------------------------------------------------------------
Key: HADOOP-4703
URL: https://issues.apache.org/jira/browse/HADOOP-4703
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.18.0
Reporter: Hairong Kuang
Fix For: 0.18.3
The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4703:
-------------------------------------------
Attachment: 4073_20081120.patch
4073_20081120.patch: change waitForProxy(...) to getProxy(...) in creating InterDatanodeProtocol and ClientDatanodeProtocol.
waitForProxy(...) waits forever if there are ConnectException. It seems not right since if the server in the other side is down, the client cannot detect it but keep waiting.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4703:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch, 4703_20081120_0.18.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649769#action_12649769 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4703:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
Running unit tests locally.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649934#action_12649934 ]
Hudson commented on HADOOP-4703:
--------------------------------
Integrated in Hadoop-trunk #668 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/668/])
. Should not wait for proxy forever in lease recovering. (szetszwo)
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch, 4703_20081120_0.18.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4703:
-------------------------------------------
Attachment: 4703_20081120_0.18.patch
4703_20081120_0.18.patch: for 0.18
I hate that I typed an incorrect jira number in my previous file name.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch, 4703_20081120_0.18.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649847#action_12649847 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4703:
------------------------------------------------
Passed all unit tests locally. I am going to commit this.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649728#action_12649728 ]
Hairong Kuang commented on HADOOP-4703:
---------------------------------------
+1 This fixed the hanging TestFileCreationClient problem that we saw while testing the patch to HADOOP-4659.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4703)
DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever
while recovering lease
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4703:
-------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
Since the change is simple, no new tests added.
> DataNode.createInterDataNodeProtocolProxy should not wait for proxy forever while recovering lease
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4703
> URL: https://issues.apache.org/jira/browse/HADOOP-4703
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Hairong Kuang
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.3
>
> Attachments: 4073_20081120.patch
>
>
> The problem is that the list of DataNodes may contain DataNode that has already shutdown as the case in TestFileCreationClient.testClientTriggeredLeaseRecovery(). Using waitForProxy causes the DataNode to wait forever for the dead DataNode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.