You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Johnny Wang <jo...@gmail.com> on 2025/04/08 08:39:21 UTC
[DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Hi all,
I would like to discuss KIP-1157.
This KIP enforces the implementation of KafkaPrincipalSerde alongside
KafkaPrincipalBuilder, which is currently only noted in the interface
comments.
Please take a look and share you thought.
https://cwiki.apache.org/confluence/x/1gq9F
Thanks,
Wang
Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Posted by Johnny Wang <jo...@gmail.com>.
Hi, PoAn
Thanks for checking. Updated the KIP to include this change.
Thanks,
Wang
PoAn Yang <ya...@gmail.com> 於 2025年5月5日 週一 下午6:11寫道:
> Hi Johnny,
>
> Thanks for the KIP.
>
> PoAn_0: Currently, the DefaultKafkaPrincipalBuilder extends both
> KafkaPrincipalBuilder and KafkaPrincipalSerde. After this KIP, will you
> change
> DefaultKafkaPrincipalBuilder to just implement KafkaPrincipalBuilder?
> If yes, you may need to include this on the KIP because it’s part of public
> class. Thanks.
>
> Best Regards,
> PoAn
>
>
> > On Apr 9, 2025, at 3:30 PM, Johnny Wang <jo...@gmail.com> wrote:
> >
> > Hi,
> >
> > Thank you for your comment. I have updated the KIP to address your
> feedback.
> >
> > Please review it at your convenience.
> >
> >
> > Thanks,
> >
> > Wang
> >
> > 黃竣陽 <s7...@gmail.com> 於 2025年4月8日 週二 下午10:00寫道:
> >
> >> Hi Johnny,
> >>
> >> Thanks for this KIP.
> >>
> >> ken_0:
> >>
> >> Doesn't this change break backward compatibility? If a user has only
> >> implemented the `KafkaPrincipalBuilder` interface, upgrading to this
> >> version would result in a compilation error. Changes that break
> >> compatibility like this typically need to be reserved for a major
> release.
> >> ken_1:
> >>
> >> While it's true that in KRaft mode, users are expected to implement both
> >> `KafkaPrincipalBuilder` and` KafkaPrincipalSerde`, the current
> motivation
> >> for this change feels a bit weak. It might be helpful to better
> emphasize
> >> why this change is necessary, and provide more context to justify the
> >> design decision.
> >>
> >> Best Regards,
> >>
> >> Jiunn-Yang
> >>
> >>
> >>> Chia-Ping Tsai <ch...@gmail.com> 於 2025年4月8日 下午5:31 寫道:
> >>>
> >>> hi Johnny
> >>>
> >>> thanks for this KIP. Some questions are listed below.
> >>>
> >>> chia_0:
> >>>
> >>> could you please update the discussion link?
> >>>
> >>> chia_1:
> >>>
> >>> There are some discussion before. For example, we can introduce new
> >>> interface consisting of KafkaPrincipalSerde and KafkaPrincipalBuilder
> to
> >>> offer better naming. Could you please add them into "Rejected
> >> Alternatives"?
> >>>
> >>> Best,
> >>> Chia-Ping
> >>>
> >>> Johnny Wang <jo...@gmail.com> 於 2025年4月8日 週二 下午4:40寫道:
> >>>
> >>>> Hi all,
> >>>> I would like to discuss KIP-1157.
> >>>>
> >>>> This KIP enforces the implementation of KafkaPrincipalSerde alongside
> >>>> KafkaPrincipalBuilder, which is currently only noted in the interface
> >>>> comments.
> >>>>
> >>>> Please take a look and share you thought.
> >>>>
> >>>> https://cwiki.apache.org/confluence/x/1gq9F
> >>>>
> >>>> Thanks,
> >>>> Wang
> >>>>
> >>
> >>
>
>
Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Posted by PoAn Yang <ya...@gmail.com>.
Hi Johnny,
Thanks for the KIP.
PoAn_0: Currently, the DefaultKafkaPrincipalBuilder extends both
KafkaPrincipalBuilder and KafkaPrincipalSerde. After this KIP, will you change
DefaultKafkaPrincipalBuilder to just implement KafkaPrincipalBuilder?
If yes, you may need to include this on the KIP because it’s part of public
class. Thanks.
Best Regards,
PoAn
> On Apr 9, 2025, at 3:30 PM, Johnny Wang <jo...@gmail.com> wrote:
>
> Hi,
>
> Thank you for your comment. I have updated the KIP to address your feedback.
>
> Please review it at your convenience.
>
>
> Thanks,
>
> Wang
>
> 黃竣陽 <s7...@gmail.com> 於 2025年4月8日 週二 下午10:00寫道:
>
>> Hi Johnny,
>>
>> Thanks for this KIP.
>>
>> ken_0:
>>
>> Doesn't this change break backward compatibility? If a user has only
>> implemented the `KafkaPrincipalBuilder` interface, upgrading to this
>> version would result in a compilation error. Changes that break
>> compatibility like this typically need to be reserved for a major release.
>> ken_1:
>>
>> While it's true that in KRaft mode, users are expected to implement both
>> `KafkaPrincipalBuilder` and` KafkaPrincipalSerde`, the current motivation
>> for this change feels a bit weak. It might be helpful to better emphasize
>> why this change is necessary, and provide more context to justify the
>> design decision.
>>
>> Best Regards,
>>
>> Jiunn-Yang
>>
>>
>>> Chia-Ping Tsai <ch...@gmail.com> 於 2025年4月8日 下午5:31 寫道:
>>>
>>> hi Johnny
>>>
>>> thanks for this KIP. Some questions are listed below.
>>>
>>> chia_0:
>>>
>>> could you please update the discussion link?
>>>
>>> chia_1:
>>>
>>> There are some discussion before. For example, we can introduce new
>>> interface consisting of KafkaPrincipalSerde and KafkaPrincipalBuilder to
>>> offer better naming. Could you please add them into "Rejected
>> Alternatives"?
>>>
>>> Best,
>>> Chia-Ping
>>>
>>> Johnny Wang <jo...@gmail.com> 於 2025年4月8日 週二 下午4:40寫道:
>>>
>>>> Hi all,
>>>> I would like to discuss KIP-1157.
>>>>
>>>> This KIP enforces the implementation of KafkaPrincipalSerde alongside
>>>> KafkaPrincipalBuilder, which is currently only noted in the interface
>>>> comments.
>>>>
>>>> Please take a look and share you thought.
>>>>
>>>> https://cwiki.apache.org/confluence/x/1gq9F
>>>>
>>>> Thanks,
>>>> Wang
>>>>
>>
>>
Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Posted by Johnny Wang <jo...@gmail.com>.
Hi,
Thank you for your comment. I have updated the KIP to address your feedback.
Please review it at your convenience.
Thanks,
Wang
黃竣陽 <s7...@gmail.com> 於 2025年4月8日 週二 下午10:00寫道:
> Hi Johnny,
>
> Thanks for this KIP.
>
> ken_0:
>
> Doesn't this change break backward compatibility? If a user has only
> implemented the `KafkaPrincipalBuilder` interface, upgrading to this
> version would result in a compilation error. Changes that break
> compatibility like this typically need to be reserved for a major release.
> ken_1:
>
> While it's true that in KRaft mode, users are expected to implement both
> `KafkaPrincipalBuilder` and` KafkaPrincipalSerde`, the current motivation
> for this change feels a bit weak. It might be helpful to better emphasize
> why this change is necessary, and provide more context to justify the
> design decision.
>
> Best Regards,
>
> Jiunn-Yang
>
>
> > Chia-Ping Tsai <ch...@gmail.com> 於 2025年4月8日 下午5:31 寫道:
> >
> > hi Johnny
> >
> > thanks for this KIP. Some questions are listed below.
> >
> > chia_0:
> >
> > could you please update the discussion link?
> >
> > chia_1:
> >
> > There are some discussion before. For example, we can introduce new
> > interface consisting of KafkaPrincipalSerde and KafkaPrincipalBuilder to
> > offer better naming. Could you please add them into "Rejected
> Alternatives"?
> >
> > Best,
> > Chia-Ping
> >
> > Johnny Wang <jo...@gmail.com> 於 2025年4月8日 週二 下午4:40寫道:
> >
> >> Hi all,
> >> I would like to discuss KIP-1157.
> >>
> >> This KIP enforces the implementation of KafkaPrincipalSerde alongside
> >> KafkaPrincipalBuilder, which is currently only noted in the interface
> >> comments.
> >>
> >> Please take a look and share you thought.
> >>
> >> https://cwiki.apache.org/confluence/x/1gq9F
> >>
> >> Thanks,
> >> Wang
> >>
>
>
Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Posted by 黃竣陽 <s7...@gmail.com>.
Hi Johnny,
Thanks for this KIP.
ken_0:
Doesn't this change break backward compatibility? If a user has only implemented the `KafkaPrincipalBuilder` interface, upgrading to this version would result in a compilation error. Changes that break compatibility like this typically need to be reserved for a major release.
ken_1:
While it's true that in KRaft mode, users are expected to implement both `KafkaPrincipalBuilder` and` KafkaPrincipalSerde`, the current motivation for this change feels a bit weak. It might be helpful to better emphasize why this change is necessary, and provide more context to justify the design decision.
Best Regards,
Jiunn-Yang
> Chia-Ping Tsai <ch...@gmail.com> 於 2025年4月8日 下午5:31 寫道:
>
> hi Johnny
>
> thanks for this KIP. Some questions are listed below.
>
> chia_0:
>
> could you please update the discussion link?
>
> chia_1:
>
> There are some discussion before. For example, we can introduce new
> interface consisting of KafkaPrincipalSerde and KafkaPrincipalBuilder to
> offer better naming. Could you please add them into "Rejected Alternatives"?
>
> Best,
> Chia-Ping
>
> Johnny Wang <jo...@gmail.com> 於 2025年4月8日 週二 下午4:40寫道:
>
>> Hi all,
>> I would like to discuss KIP-1157.
>>
>> This KIP enforces the implementation of KafkaPrincipalSerde alongside
>> KafkaPrincipalBuilder, which is currently only noted in the interface
>> comments.
>>
>> Please take a look and share you thought.
>>
>> https://cwiki.apache.org/confluence/x/1gq9F
>>
>> Thanks,
>> Wang
>>
Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder
Posted by Chia-Ping Tsai <ch...@gmail.com>.
hi Johnny
thanks for this KIP. Some questions are listed below.
chia_0:
could you please update the discussion link?
chia_1:
There are some discussion before. For example, we can introduce new
interface consisting of KafkaPrincipalSerde and KafkaPrincipalBuilder to
offer better naming. Could you please add them into "Rejected Alternatives"?
Best,
Chia-Ping
Johnny Wang <jo...@gmail.com> 於 2025年4月8日 週二 下午4:40寫道:
> Hi all,
> I would like to discuss KIP-1157.
>
> This KIP enforces the implementation of KafkaPrincipalSerde alongside
> KafkaPrincipalBuilder, which is currently only noted in the interface
> comments.
>
> Please take a look and share you thought.
>
> https://cwiki.apache.org/confluence/x/1gq9F
>
> Thanks,
> Wang
>