You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "spark shen (JIRA)" <ji...@apache.org> on 2006/08/04 10:47:14 UTC
[jira] Created: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
[classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
-----------------------------------------------------------------------------------------------------------------
Key: HARMONY-1066
URL: http://issues.apache.org/jira/browse/HARMONY-1066
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: spark shen
java.util.TreeMap.headMap(Object) & tailMap(Object) methods
do not return serializable SortedMap. But this is not the case on RI.
Testcase
public void test_headMapLObject_Serializable() {
TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
map.put(1, 2.1);
map.put(2, 3.1);
map.put(3, 4.5);
map.put(7, 21.3);
SortedMap<Integer, Double> headMap = map.headMap(2);
assertTrue(headMap instanceof Serializable);
SortedMap<Integer, Double> tailMap = map.tailMap(3);
assertTrue(tailMap instanceof Serializable);
}
This test case will fail on Harmony, pass on RI.
I will attach a patch to fix this problem.
Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=all ]
Paulex Yang closed HARMONY-1066.
--------------------------------
Verified by Spark.
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Assigned To: Paulex Yang
> Attachments: Harmony-1066.diff, Harmony-1066_serialization.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=comments#action_12428305 ]
spark shen commented on HARMONY-1066:
-------------------------------------
Hi paulex, the patch works fine. Thank you.
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Assigned To: Paulex Yang
> Attachments: Harmony-1066.diff, Harmony-1066_serialization.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=all ]
spark shen updated HARMONY-1066:
--------------------------------
Attachment: Harmony-1066.diff
Would you please try this patch?
Best regards
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Attachments: Harmony-1066.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=comments#action_12425751 ]
Tim Ellison commented on HARMONY-1066:
--------------------------------------
Spark,
Do you have a test to show that the sub-map is serialization compatible with the RI? e.g. your patch does not include a SUID.
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Attachments: Harmony-1066.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=all ]
spark shen updated HARMONY-1066:
--------------------------------
Attachment: Harmony-1066_serialization.diff
This patch adds serialization tests. Would you please try this patch?
Best regards
Spark Shen
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Attachments: Harmony-1066.diff, Harmony-1066_serialization.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=all ]
Paulex Yang resolved HARMONY-1066.
----------------------------------
Resolution: Fixed
Spark, patch applied at revision r430759, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Assigned To: Paulex Yang
> Attachments: Harmony-1066.diff, Harmony-1066_serialization.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=all ]
Paulex Yang reassigned HARMONY-1066:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Assigned To: Paulex Yang
> Attachments: Harmony-1066.diff, Harmony-1066_serialization.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1066) [classlib][luni]
java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return
serializable SortedMap
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1066?page=comments#action_12426104 ]
spark shen commented on HARMONY-1066:
-------------------------------------
I did not pay attention to this problem, and I will submit another patch soon.
Best regards
Spark shen
> [classlib][luni] java.util.TreeMap.headMap(Object) & tailMap(Object) methods do not return serializable SortedMap
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1066
> URL: http://issues.apache.org/jira/browse/HARMONY-1066
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: spark shen
> Attachments: Harmony-1066.diff
>
>
> java.util.TreeMap.headMap(Object) & tailMap(Object) methods
> do not return serializable SortedMap. But this is not the case on RI.
> Testcase
> public void test_headMapLObject_Serializable() {
> TreeMap<Integer, Double> map = new TreeMap<Integer, Double>();
> map.put(1, 2.1);
> map.put(2, 3.1);
> map.put(3, 4.5);
> map.put(7, 21.3);
> SortedMap<Integer, Double> headMap = map.headMap(2);
> assertTrue(headMap instanceof Serializable);
> SortedMap<Integer, Double> tailMap = map.tailMap(3);
> assertTrue(tailMap instanceof Serializable);
> }
> This test case will fail on Harmony, pass on RI.
> I will attach a patch to fix this problem.
> Best regards
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira