You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Franklin Hu (JIRA)" <ji...@apache.org> on 2011/08/03 20:49:28 UTC

[jira] [Created] (HIVE-2343) stats not updated for non "load table desc" operations

stats not updated for non "load table desc" operations
------------------------------------------------------

                 Key: HIVE-2343
                 URL: https://issues.apache.org/jira/browse/HIVE-2343
             Project: Hive
          Issue Type: Bug
            Reporter: Franklin Hu


Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Franklin Hu reassigned HIVE-2343:
---------------------------------

    Assignee: Franklin Hu

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Franklin Hu updated HIVE-2343:
------------------------------

    Attachment: hive-2343.1.patch

Fix NPE, add unit test

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Franklin Hu updated HIVE-2343:
------------------------------

    Affects Version/s:     (was: 0.7.1)

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079004#comment-13079004 ] 

jiraposter@reviews.apache.org commented on HIVE-2343:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1279/
-----------------------------------------------------------

Review request for Ning Zhang.


Summary
-------

table stats were not being updated for non "load table desc" plans due to NPE.


This addresses bug hive-2343.
    https://issues.apache.org/jira/browse/hive-2343


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1153601 
  trunk/ql/src/test/queries/clientpositive/stats16.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/stats16.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1279/diff


Testing
-------

all clientpositive/stats* unit tests pass


Thanks,

Franklin



> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ning Zhang updated HIVE-2343:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed. Thanks Franklin!

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078963#comment-13078963 ] 

Ning Zhang commented on HIVE-2343:
----------------------------------

+1. Will commit if tests pass. 

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079306#comment-13079306 ] 

Hudson commented on HIVE-2343:
------------------------------

Integrated in Hive-trunk-h0.21 #872 (See [https://builds.apache.org/job/Hive-trunk-h0.21/872/])
    HIVE-2343. stats are not updated for non "load table desc" operations" (Franklin Hu via Ning Zhang)

nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153753
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java
* /hive/trunk/ql/src/test/queries/clientpositive/stats16.q
* /hive/trunk/ql/src/test/results/clientpositive/stats16.q.out


> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Franklin Hu updated HIVE-2343:
------------------------------

          Component/s: Query Processor
          Description: Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.  (was: Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations.)
    Affects Version/s: 0.7.1

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2343) stats not updated for non "load table desc" operations

Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Franklin Hu updated HIVE-2343:
------------------------------

    Fix Version/s: 0.8.0
           Status: Patch Available  (was: Open)

> stats not updated for non "load table desc" operations
> ------------------------------------------------------
>
>                 Key: HIVE-2343
>                 URL: https://issues.apache.org/jira/browse/HIVE-2343
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.7.1
>            Reporter: Franklin Hu
>            Assignee: Franklin Hu
>             Fix For: 0.8.0
>
>         Attachments: hive-2343.1.patch
>
>
> Bug introduced in HIVE-306 so that stats are updated only for LoadTableDesc operations. For other operations (analyze table), null ptr is thrown and stats are not updated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira