[GitHub] [knox] risdenk commented on a change in pull request #68: KNOX-1814 - Moving conf/data folder checking to Java layer from bash

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #68: KNOX-1814 - Moving conf/data folder checking to Java layer from bash
URL: https://github.com/apache/knox/pull/68#discussion_r264238280
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java
 ##########
 @@ -269,10 +280,28 @@ private static void validateKerberosConfig(GatewayConfig config) throws GatewayC
   }
 
   private static void checkIfFileExistsAndCanBeRead(File fileToBeChecked, String propertyName, Set<String> errors) {
+    checkIfFileExistsAndCanBeRead(fileToBeChecked, propertyName, errors, false);
+  }
+
+  private static void checkIfDirectoryExistsAndCanBeRead(File fileToBeChecked, String propertyName, Set<String> errors) {
 
 Review comment:
   Since these are new methods can we pass in a `Path` instead of a `File`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services