[GitHub] [hbase] saintstack commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2780:
URL: https://github.com/apache/hbase/pull/2780#discussion_r594762484



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1127,7 +1128,9 @@ private boolean isTableInGroup(TableName tableName, String groupName,
           .isTableState(tn, TableState.State.DISABLED, TableState.State.DISABLING)) {
           continue;
         }
-        if (region.isSplitParent()) {
+        if (
+          regionStates.getOrCreateRegionStateNode(region).getState().equals(RegionState.State.SPLIT)

Review comment:
       getOrCreateRegionStateNode could have a side-effect when there is no RegionStateNode for 'region'. In this case, we'll add to RegionState a new RSN for 'region' if none present.... Do we want to do this? 
   
   You make the above call because you don't have access to the internal createRegionStateNode(regionInfo ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org