You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2024/09/24 20:21:32 UTC
[PR] Add support for cert verifycation to QUIC [trafficserver]
maskit opened a new pull request, #11787:
URL: https://github.com/apache/trafficserver/pull/11787
This extends `TLSBasicSupport` to add the ability to verify certificates.
With this change, QUICNetVC supports the verification and we have one less dynamic_cast to SSLNetVC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for cert verification to QUIC [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #11787:
URL: https://github.com/apache/trafficserver/pull/11787#discussion_r1776762527
##########
include/iocore/net/TLSBasicSupport.h:
##########
@@ -47,11 +47,30 @@ class TLSBasicSupport
const char *get_tls_curve() const;
ink_hrtime get_tls_handshake_begin_time() const;
ink_hrtime get_tls_handshake_end_time() const;
+ /**
+ * Returns a certificate that neeed to be verified.
Review Comment:
need
##########
include/iocore/net/TLSBasicSupport.h:
##########
@@ -47,11 +47,30 @@ class TLSBasicSupport
const char *get_tls_curve() const;
ink_hrtime get_tls_handshake_begin_time() const;
ink_hrtime get_tls_handshake_end_time() const;
+ /**
+ * Returns a certificate that neeed to be verified.
+ *
+ * Note: This function is only available during verify_certification is being called.
Review Comment:
s/during/when ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for cert verification to QUIC [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #11787:
URL: https://github.com/apache/trafficserver/pull/11787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for cert verification to QUIC [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11787:
URL: https://github.com/apache/trafficserver/pull/11787#issuecomment-2374890522
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org