You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "B. W. Fitzpatrick" <fi...@red-bean.com> on 2001/03/15 14:12:07 UTC
Re: CVS update: subversion/subversion/client checkout-cmd.c
One nt: Since only one --destination is passed during checkout,
shouldn't the code you added be outside of the loop?
-Fitz
> User: sussman
> Date: 01/03/15 06:00:05
>
> Modified: subversion/client checkout-cmd.c
> Log:
> (svn_cl__checkout): use basename of url if -d isn't specified.
>
> Revision Changes Path
> 1.14 +11 -2 subversion/subversion/client/checkout-cmd.c
>
> Index: checkout-cmd.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/client/checkout-cmd.c,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -r1.13 -r1.14
> --- checkout-cmd.c 2001/03/15 08:39:05 1.13
> +++ checkout-cmd.c 2001/03/15 14:00:04 1.14
> @@ -81,12 +81,21 @@
> */
> for (i = 0; i < opt_state->args->nelts; i++)
> {
> + svn_string_t *local_dir;
> svn_string_t *repos_url
> = ((svn_string_t **) (opt_state->args->elts))[0];
> +
> + /* Ensure that we have a default dir to checkout into. */
> + if (! opt_state->target)
> + local_dir = svn_path_last_component (repos_url,
> + svn_path_local_style,
> + pool);
> + else
> + local_dir = opt_state->target;
>
> err = svn_cl__get_trace_update_editor (&trace_editor,
> &trace_edit_baton,
> - opt_state->target,
> + local_dir,
> pool);
> if (err)
> return err;
> @@ -95,7 +104,7 @@
> err = svn_client_checkout (NULL, NULL,
> trace_editor, trace_edit_baton,
> repos_url,
> - opt_state->target,
> + local_dir,
> opt_state->revision,
> opt_state->xml_file,
> pool);
>
>
>
>
Re: CVS update: subversion/subversion/client checkout-cmd.c
Posted by Ben Collins-Sussman <su...@newton.ch.collab.net>.
"B. W. Fitzpatrick" <fi...@red-bean.com> writes:
> One nt: Since only one --destination is passed during checkout,
> shouldn't the code you added be outside of the loop?
Mmmm, yeah, I guess so. :)
>
> -Fitz
>
> > User: sussman
> > Date: 01/03/15 06:00:05
> >
> > Modified: subversion/client checkout-cmd.c
> > Log:
> > (svn_cl__checkout): use basename of url if -d isn't specified.
> >
> > Revision Changes Path
> > 1.14 +11 -2 subversion/subversion/client/checkout-cmd.c
> >
> > Index: checkout-cmd.c
> > ===================================================================
> > RCS file: /cvs/subversion/subversion/client/checkout-cmd.c,v
> > retrieving revision 1.13
> > retrieving revision 1.14
> > diff -u -r1.13 -r1.14
> > --- checkout-cmd.c 2001/03/15 08:39:05 1.13
> > +++ checkout-cmd.c 2001/03/15 14:00:04 1.14
> > @@ -81,12 +81,21 @@
> > */
> > for (i = 0; i < opt_state->args->nelts; i++)
> > {
> > + svn_string_t *local_dir;
> > svn_string_t *repos_url
> > = ((svn_string_t **) (opt_state->args->elts))[0];
> > +
> > + /* Ensure that we have a default dir to checkout into. */
> > + if (! opt_state->target)
> > + local_dir = svn_path_last_component (repos_url,
> > + svn_path_local_style,
> > + pool);
> > + else
> > + local_dir = opt_state->target;
> >
> > err = svn_cl__get_trace_update_editor (&trace_editor,
> > &trace_edit_baton,
> > - opt_state->target,
> > + local_dir,
> > pool);
> > if (err)
> > return err;
> > @@ -95,7 +104,7 @@
> > err = svn_client_checkout (NULL, NULL,
> > trace_editor, trace_edit_baton,
> > repos_url,
> > - opt_state->target,
> > + local_dir,
> > opt_state->revision,
> > opt_state->xml_file,
> > pool);
> >
> >
> >
> >