You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Benjamin Staffin <be...@gmail.com> on 2016/03/31 04:34:15 UTC
Review Request 45521: Remove client-side validation of environment
names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/
-----------------------------------------------------------
Review request for Aurora.
Bugs: AURORA-319
https://issues.apache.org/jira/browse/AURORA-319
Repository: aurora
Description
-------
This should be done in the scheduler, if anywhere.
Diffs
-----
src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
Diff: https://reviews.apache.org/r/45521/diff/
Testing
-------
Thanks,
Benjamin Staffin
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126298
-----------------------------------------------------------
Couple of thoughts on this:
* Cool feature! We'd probably use that as well
* I believe it does still make sense to have a scheduler-side validation. Otherwise this could lead to total chaos
* Whatever we do, docs have to be kept in sync :-): https://github.com/apache/aurora/blob/master/docs/features/multitenancy.md#job-namespaces Doing a quick search however indicates that there are atleast 3 other places that also list the currently hard coded environment names
- Stephan Erb
On March 31, 2016, 7:55 a.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 7:55 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Benjamin Staffin <be...@gmail.com>.
> On March 30, 2016, 11:15 p.m., Aurora ReviewBot wrote:
> > Master (193f17e) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
> > [1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
> > [1m [0m
> > [1m assert hct._total_latency == 0[0m
> > [1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
> > [1m [0m
> > [1m # start the health check (during health check it is still 0)[0m
> > [1m epsilon = 0.001[0m
> > [1m self._clock.tick(1.0 + epsilon)[0m
> > [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
> > [1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
> > [1m assert hct._total_latency == 0[0m
> > [1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
> > [1m assert hct.metrics.sample()['checks'] == 0[0m
> > [1m [0m
> > [1m # finish the health check[0m
> > [1m self._clock.tick(0.5 + epsilon)[0m
> > [1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
> > [1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
> > [1m> assert hct._total_latency == 0.5[0m
> > [1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
> > [1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f2a4f271c50>._total_latency[0m
> >
> > src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
> > -------------- Captured stderr call --------------
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 0.0
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 0.0
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.0
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.001
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.001
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.501
> > [<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.502
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> > [1m[31m 2 failed, 667 passed, 5 skipped, 1 warnings in 209.54 seconds [0m
> >
> > FAILURE
> >
> >
> > 06:07:16 04:23 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
@ReviewBot retry
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126276
-----------------------------------------------------------
On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 10:55 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126276
-----------------------------------------------------------
Master (193f17e) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f2a4f271c50>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7f2a4f271f10>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 2 failed, 667 passed, 5 skipped, 1 warnings in 209.54 seconds [0m
FAILURE
06:07:16 04:23 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 31, 2016, 5:55 a.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 5:55 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Benjamin Staffin <be...@gmail.com>.
> On March 31, 2016, 10 a.m., Joshua Cohen wrote:
> > Just to be sure, I saw in the IRC discussion yesterday that Bill suggested adding the ability for scheduler-side configuration to replace this.
> >
> > I'm a strong -1 to this client change without the accompanying scheduler change.
>
> Bill Farner wrote:
> I concur. This could be as little as a regexp specified on the scheduler command line.
we're all on the same page here - I just haven't written the scheduler half of this change yet.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126344
-----------------------------------------------------------
On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 10:55 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Bill Farner <wf...@apache.org>.
> On March 31, 2016, 10 a.m., Joshua Cohen wrote:
> > Just to be sure, I saw in the IRC discussion yesterday that Bill suggested adding the ability for scheduler-side configuration to replace this.
> >
> > I'm a strong -1 to this client change without the accompanying scheduler change.
I concur. This could be as little as a regexp specified on the scheduler command line.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126344
-----------------------------------------------------------
On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 10:55 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126344
-----------------------------------------------------------
Just to be sure, I saw in the IRC discussion yesterday that Bill suggested adding the ability for scheduler-side configuration to replace this.
I'm a strong -1 to this client change without the accompanying scheduler change.
- Joshua Cohen
On March 31, 2016, 5:55 a.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 5:55 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Benjamin Staffin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/
-----------------------------------------------------------
(Updated March 30, 2016, 10:55 p.m.)
Review request for Aurora.
Bugs: AURORA-319
https://issues.apache.org/jira/browse/AURORA-319
Repository: aurora
Description
-------
This should be done in the scheduler, if anywhere.
Diffs (updated)
-----
src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
Diff: https://reviews.apache.org/r/45521/diff/
Testing
-------
Thanks,
Benjamin Staffin
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126252
-----------------------------------------------------------
Master (193f17e) is red with this patch.
./build-support/jenkins/build.sh
03:06:08 00:01 [imports]
03:06:08 00:01 [ivy-imports]
03:06:08 00:01 [unpack-jars]
03:06:08 00:01 [unpack-jars]
03:06:08 00:01 [deferred-sources]
03:06:08 00:01 [deferred-sources]
03:06:08 00:01 [gen]
03:06:08 00:01 [thrift]
03:06:08 00:01 [protoc]
03:06:08 00:01 [antlr]
03:06:08 00:01 [ragel]
03:06:08 00:01 [jaxb]
03:06:08 00:01 [wire]
03:06:08 00:01 [jvm-platform-validate]
03:06:08 00:01 [jvm-platform-validate]
03:06:08 00:01 [resolve]
03:06:08 00:01 [ivy]
03:06:08 00:01 [bootstrap-nailgun-server]
03:06:08 00:01 [compile]
03:06:08 00:01 [compile-jvm-prep-command]
03:06:08 00:01 [jvm_prep_command]
03:06:08 00:01 [compile-prep-command]
03:06:08 00:01 [python-eval]
03:06:08 00:01 [pythonstyle]
03:06:09 00:02 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
F821:ERROR src/main/python/apache/aurora/common/aurora_job_key.py:031 undefined name 're'
| VALID_IDENTIFIER = re.compile(GOOD_IDENTIFIER_PATTERN_PYTHON)
F401:ERROR src/main/python/apache/aurora/client/config.py:022 're' imported but unused
|import re
FAILURE: Python Style issues found
03:06:25 00:18 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 31, 2016, 2:58 a.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:58 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
> src/main/python/apache/aurora/common/aurora_job_key.py 21cdca6074c6fa58d68a0818805144662044841f
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Benjamin Staffin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/
-----------------------------------------------------------
(Updated March 30, 2016, 7:58 p.m.)
Review request for Aurora.
Bugs: AURORA-319
https://issues.apache.org/jira/browse/AURORA-319
Repository: aurora
Description
-------
This should be done in the scheduler, if anywhere.
Diffs (updated)
-----
src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
src/main/python/apache/aurora/common/aurora_job_key.py 21cdca6074c6fa58d68a0818805144662044841f
Diff: https://reviews.apache.org/r/45521/diff/
Testing
-------
Thanks,
Benjamin Staffin
Re: Review Request 45521: Remove client-side validation of
environment names
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126250
-----------------------------------------------------------
Master (193f17e) is red with this patch.
./build-support/jenkins/build.sh
Executing tasks in goals: bootstrap -> imports -> unpack-jars -> deferred-sources -> gen -> jvm-platform-validate -> resolve -> compile -> resources -> test[0m
02:47:45 00:00 [bootstrap]
02:47:45 00:00 [jar-dependency-management]
02:47:45 00:00 [bootstrap-jvm-tools]
02:47:45 00:00 [imports]
02:47:45 00:00 [ivy-imports]
02:47:45 00:00 [unpack-jars]
02:47:45 00:00 [unpack-jars]
02:47:45 00:00 [deferred-sources]
02:47:45 00:00 [deferred-sources]
02:47:45 00:00 [gen]
02:47:45 00:00 [thrift]
02:47:45 00:00 [protoc]
02:47:45 00:00 [antlr]
02:47:45 00:00 [ragel]
02:47:45 00:00 [jaxb]
02:47:45 00:00 [wire]
02:47:45 00:00 [jvm-platform-validate]
02:47:45 00:00 [jvm-platform-validate]
02:47:45 00:00 [resolve]
02:47:45 00:00 [ivy]
02:47:45 00:00 [bootstrap-nailgun-server]
02:47:46 00:01 [compile]
02:47:46 00:01 [compile-jvm-prep-command]
02:47:46 00:01 [jvm_prep_command]
02:47:46 00:01 [compile-prep-command]
02:47:46 00:01 [python-eval]
02:47:46 00:01 [pythonstyle]
02:47:46 00:01 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
F401:ERROR src/main/python/apache/aurora/client/config.py:022 're' imported but unused
|import re
FAILURE: Python Style issues found
02:48:02 00:17 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 31, 2016, 2:34 a.m., Benjamin Staffin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:34 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-319
> https://issues.apache.org/jira/browse/AURORA-319
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be done in the scheduler, if anywhere.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e
>
> Diff: https://reviews.apache.org/r/45521/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Staffin
>
>