Re: [PR] Allow Variable and XCom set and delete from trigger code [airflow]

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #53514:
URL: https://github.com/apache/airflow/pull/53514#discussion_r2250694149


##########
airflow-core/tests/unit/jobs/test_triggerer_job.py:
##########
@@ -687,8 +712,8 @@ def handle_events(self):
 
 @pytest.mark.asyncio
 @pytest.mark.execution_timeout(20)
-async def test_trigger_can_access_variables_connections_and_xcoms(session, dag_maker):
-    """Checks that the trigger will successfully access Variables, Connections and XComs."""
+async def test_trigger_can_call_variables_connections_and_xcoms_methods(session, dag_maker):

Review Comment:
   I understand your concern but we are only setting the fields in trigger event on successful flow of control so its almost guaranteed that `variable.set` or other things did what they were supposed to. Even if they didn't internally, that should not be tested at a superficial layer on top of them, we have separate tests that test those for them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org