You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andreas Köhler (Updated JIRA)" <ji...@apache.org> on 2011/11/19 21:22:52 UTC
[jira] [Updated] (WICKET-4245) AbstractResourceAggregatingHeaderResponse forgets some information about references

     [ https://issues.apache.org/jira/browse/WICKET-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Köhler updated WICKET-4245:
-----------------------------------

    Description: 
Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java

    public void renderJavaScriptReference(String url, String id, boolean defer)
    {
        topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null,
	    ResourceType.JS, defer, null, null));
    }
forgets the id.

    public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
        String media, String condition)
    {
     	topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media,
            ResourceType.CSS, false, null, condition));
    }
forgets the page parameters.

I think a quickstart should not be necessary.

  was:
Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java

{code}
    public void renderJavaScriptReference(String url, String id, boolean defer)
    {
        topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null,
	    ResourceType.JS, defer, null, null));
    }
{code}
forgets the id.

{code}
    public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
        String media, String condition)
    {
     	topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media,
            ResourceType.CSS, false, null, condition));
    }
{code}
forgets the page parameters.

I think a quickstart should not be necessary.

    
> AbstractResourceAggregatingHeaderResponse forgets some information about references
> -----------------------------------------------------------------------------------
>
>                 Key: WICKET-4245
>                 URL: https://issues.apache.org/jira/browse/WICKET-4245
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.3
>            Reporter: Andreas Köhler
>            Priority: Minor
>
> Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java
>     public void renderJavaScriptReference(String url, String id, boolean defer)
>     {
>         topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null,
> 	    ResourceType.JS, defer, null, null));
>     }
> forgets the id.
>     public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
>         String media, String condition)
>     {
>      	topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media,
>             ResourceType.CSS, false, null, condition));
>     }
> forgets the page parameters.
> I think a quickstart should not be necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira