[GitHub] [doris] eldenmoon commented on a diff in pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table

["eldenmoon (via GitHub)" <gi...@apache.org>]

eldenmoon commented on code in PR #16185:
URL: https://github.com/apache/doris/pull/16185#discussion_r1090214262


##########
regression-test/suites/query_p0/sort/sort.groovy:
##########
@@ -23,4 +23,22 @@ suite("sort") {
     qt_sort_string_single_column """ select * from ( select '汇总' as a union all select '2022-01-01' as a ) a order by 1 """
     qt_sort_string_multiple_columns """ select * from ( select '汇总' as a,1 as b union all select '2022-01-01' as a,1 as b ) a order by 1,2 """
     qt_sort_string_on_fe """ select '汇总' > '2022-01-01' """
+
+    sql """CREATE TABLE IF NOT EXISTS NO2PhaseSortWhenAggTable

Review Comment:
   `2PhaseSortWhenAggTable` could be more correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org