You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/02 20:15:28 UTC

[GitHub] [iceberg] samredai commented on a diff in pull request #4675: Docs: Document register table support of HiveCatalog

samredai commented on code in PR #4675:
URL: https://github.com/apache/iceberg/pull/4675#discussion_r863157487


##########
docs/api/java-api-quickstart.md:
##########
@@ -66,6 +66,17 @@ Table table = catalog.createTable(name, schema, spec);
 
 The logs [schema](#create-a-schema) and [partition spec](#create-a-partition-spec) are created below.
 
+HiveCatalog supports registering the table using an existing metadata JSON file as below:

Review Comment:
   Agreed I don't think this should go in the quickstart. Mainly because someone new to Iceberg landing here to try the Java API for the first time won't have an existing metadata file and a configured `HiveCatalog` to register it as a table. I'd say a better place is [java-api.md](https://github.com/apache/iceberg/blob/master/docs/api/java-api.md) which will be with the versioned docs. (Quickstarts will eventually be moved to the common docs)
   
   @ajantha-bhat what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org