You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/12/02 18:56:37 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1227: SAMZA-2404: Container Placement Handler for dispatching container placement messages between metastore and JobCoordinator

rmatharu commented on a change in pull request #1227: SAMZA-2404: Container Placement Handler for dispatching container placement messages between metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r352769888
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
 ##########
 @@ -97,6 +100,8 @@
 
   // The ContainerManager manages control actions for both active & standby containers
   private final ContainerManager containerManager;
+  private ContainerPlacementHandler containerPlacementHandler;
+  private Thread containerPlacementHandlerThread;
 
 Review comment:
   Please use ExecutorService executorService = Executors.newSingleThreadExecutor(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services