You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pons Rudy (JIRA)" <ji...@apache.org> on 2010/06/02 19:05:43 UTC
[jira] Created: (HARMONY-6539) [classlib][awt] Default font should
have only logical name set to "Default"
[classlib][awt] Default font should have only logical name set to "Default"
---------------------------------------------------------------------------
Key: HARMONY-6539
URL: https://issues.apache.org/jira/browse/HARMONY-6539
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Pons Rudy
When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6539) [classlib][awt] Default font
should have only logical name set to "Default"
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875059#action_12875059 ]
Mark Hindess commented on HARMONY-6539:
---------------------------------------
Rudy, please can you create a regression test for this issue (and any others)?
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Priority: Minor
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6539) [classlib][awt] Default font
should have only logical name set to "Default"
Posted by "Pons Rudy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879375#action_12879375 ]
Pons Rudy commented on HARMONY-6539:
------------------------------------
Hmm, after some test on RI :
System.out.println(new Font(null));
print
java.awt.Font[family=Dialog,name=Dialog,style=plain,size=12]
on Java 5 but
java.awt.Font[family=Dialog,name=Default,style=plain,size=12]
on Java 6.
and System.out.println(new Font("dialog", Font.PLAIN, 12));
print
java.awt.Font[family=Dialog,name=dialog,style=plain,size=12]
both on Java 5 and 6, never name=Dialog. So I think we could keep current behaviour on Harmony. Should I ask for this on the mailing list ?
Also, I don't really know how to make regressions test properly. I can't use assertEquals on newFont(null).getFamilyName(), because for you it returns Dialog, for me it returns DejaVu Sans. I could use asserNotEquals with default or Default, but it's quite limited...
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Priority: Minor
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6539) [classlib][awt] Default font should
have only logical name set to "Default"
Posted by "Pons Rudy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pons Rudy updated HARMONY-6539:
-------------------------------
Attachment: HARMONY-6539.patch
Change FontManager to not set family, PS and face name to default when creating a default font, and change the default logical name from "default" to "Default", as writen in the documentation
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6539) [classlib][awt] Default font should
have only logical name set to "Default"
Posted by "Pons Rudy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pons Rudy updated HARMONY-6539:
-------------------------------
Priority: Minor (was: Major)
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Priority: Minor
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6539) [classlib][awt] Default font
should have only logical name set to "Default"
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879364#action_12879364 ]
Tim Ellison commented on HARMONY-6539:
--------------------------------------
Even with the patch included when I run
System.out.println(new Font(null));
on the Sun code I get
java.awt.Font[family=Dialog,name=Dialog,style=plain,size=12]
but on Harmony I still get the name "Default", as in:
java.awt.Font[family=Dialog,name=Default,style=plain,size=12]
This name is being set in Font.java:139 right?
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Priority: Minor
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6539) [classlib][awt] Default font
should have only logical name set to "Default"
Posted by "Pons Rudy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879369#action_12879369 ]
Pons Rudy commented on HARMONY-6539:
------------------------------------
This name set in Font.java:139 is correct, it's the logical font name, that should be Default. The Harmony difference you have seen is caused by Font.toString() :
This method use this.name. It should use this.getFontName() instead to have the same result than on RI. I will provide a new patch with regression test and correction in toString method.
> [classlib][awt] Default font should have only logical name set to "Default"
> ---------------------------------------------------------------------------
>
> Key: HARMONY-6539
> URL: https://issues.apache.org/jira/browse/HARMONY-6539
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Pons Rudy
> Priority: Minor
> Attachments: HARMONY-6539.patch
>
>
> When creating a default font (like with new Font(null)), the logical, ps, family and face name are all set to "default", but specs says only the logical name should set to "Default".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.