You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2018/03/05 09:53:42 UTC

[GitHub] CptBartender commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder

CptBartender commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/3#issuecomment-370366380
 
 
   @chetanmeh I've added some simple JUnit tests as well as fixed one conrnercase where loggers for similarly-named packages might end up using wrong layouts - probably wouldn't occur in AEM setup, but it theoretically can happen and thus is a bug - I've added a test case for it as well.
   
   If the code is ok as-is, then please let me know if it would be possible to release it soon as 5.1.3, otherwise please let me know your thoughts on the code.
   
   Cheers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services