You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/04 10:50:41 UTC
[GitHub] [hive] pgaref opened a new pull request #1943: HIVE-23036: Incorrect ORC PPD eval with sub-millisecond timestamps
pgaref opened a new pull request #1943:
URL: https://github.com/apache/hive/pull/1943
### What changes were proposed in this pull request?
Timestamp PPD Test with nanosecond precision
### Why are the changes needed?
Nanosecond precision timestamps where not supported prior to ORC-1.6 thus we need to add some tests
### Does this PR introduce _any_ user-facing change?
Np
### How was this patch tested?
orc_ppd_timestamp_precision.q
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog merged pull request #1943: HIVE-23036: [TEST] ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
abstractdog merged pull request #1943:
URL: https://github.com/apache/hive/pull/1943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #1943: HIVE-23036: ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #1943:
URL: https://github.com/apache/hive/pull/1943#issuecomment-774199615
let's append something like "test coverage" to the commit message as it's only a test, no changes in PPD, okay @pgaref ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref edited a comment on pull request #1943: HIVE-23036: [TEST] ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
pgaref edited a comment on pull request #1943:
URL: https://github.com/apache/hive/pull/1943#issuecomment-774205883
Hey @abstractdog -- sure, just added this as part of the PR title (I believe thats what the commit message is capturing). It may be altered during merging as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #1943: HIVE-23036: [TEST] ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #1943:
URL: https://github.com/apache/hive/pull/1943#issuecomment-775351617
merged to master, thanks @pgaref for the patch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on pull request #1943: HIVE-23036: ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #1943:
URL: https://github.com/apache/hive/pull/1943#issuecomment-773924460
cc @abstractdog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on pull request #1943: HIVE-23036: [TEST] ORC PPD eval with sub-millisecond timestamps
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #1943:
URL: https://github.com/apache/hive/pull/1943#issuecomment-774205883
Hey @abstractdog -- sure, just added this as part of the PR title (I believe thats what the commit message is capturing). It may altered during merging as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org