You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Li Ping Zhang (JIRA)" <ji...@apache.org> on 2012/11/07 23:58:12 UTC
[jira] [Created] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Li Ping Zhang created HBASE-7120:
------------------------------------
Summary: hbase-daemon.sh (start) missing necessary check when writing pid and log files
Key: HBASE-7120
URL: https://issues.apache.org/jira/browse/HBASE-7120
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0
Environment: RHEL 5.3, open JDK 1.6
Reporter: Li Ping Zhang
$HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code chek, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-7120 started by Li Ping Zhang.
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492795#comment-13492795 ]
stack commented on HBASE-7120:
------------------------------
Do you have a patch for us Li?
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code chek, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Ping Zhang reassigned HBASE-7120:
------------------------------------
Assignee: Li Ping Zhang
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496593#comment-13496593 ]
stack commented on HBASE-7120:
------------------------------
Add your patch here [~michelle]?
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Ping Zhang updated HBASE-7120:
---------------------------------
Attachment: HBASE-7120-trunk.patch
HBASE-7120-trunk.patch is for trunk.
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Attachments: HBASE-7120-0.94.patch, HBASE-7120-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506548#comment-13506548 ]
stack commented on HBASE-7120:
------------------------------
Agree that not having a pid will mess up our being able to stop the process. I think though that failing to write a pid is a reason sufficient not to start hbase. Can you store the pid in a variable in the start script and kill hbase if we fail writing the pid file? Similar w/ log files. If we can't write a log file, we should again fail the startup. What do you think [~michelle]?
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Attachments: HBASE-7120-0.94.patch, HBASE-7120-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496342#comment-13496342 ]
Li Ping Zhang commented on HBASE-7120:
--------------------------------------
Yes, Stack, I have the patch generated from 0.94 branch and trunk, can I patch it?
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Ping Zhang updated HBASE-7120:
---------------------------------
Description:
$HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
was:
$HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code chek, it's better to do necessary check when writing pid and log files.
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Labels: patch
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Ping Zhang updated HBASE-7120:
---------------------------------
Attachment: HBASE-7120-0.94.patch
Attached the patch for branch 0.94.
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Attachments: HBASE-7120-0.94.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505672#comment-13505672 ]
stack commented on HBASE-7120:
------------------------------
In patch, if we fail, I see we echo a message. Should we not also fail the startup if we can't write a pid file?
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Attachments: HBASE-7120-0.94.patch, HBASE-7120-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7120) hbase-daemon.sh (start) missing
necessary check when writing pid and log files
Posted by "Li Ping Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506282#comment-13506282 ]
Li Ping Zhang commented on HBASE-7120:
--------------------------------------
Yes, Stack, the patch will not interrupt the process if it can't write a log or pid file. I think for startup procedure, failing to write a pid file will impact "stop" procedure in hbase-daemon.sh when it use pid file to stop process, but it will not impact the real deamon to start process, anyhow giving warning messgae is needed.
> hbase-daemon.sh (start) missing necessary check when writing pid and log files
> ------------------------------------------------------------------------------
>
> Key: HBASE-7120
> URL: https://issues.apache.org/jira/browse/HBASE-7120
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Environment: RHEL 5.3, open JDK 1.6
> Reporter: Li Ping Zhang
> Assignee: Li Ping Zhang
> Labels: patch
> Attachments: HBASE-7120-0.94.patch, HBASE-7120-trunk.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> $HBASE_HOME/bin/hbase-daemon.sh exit code is Zero, when runing hbase-daemon.sh failed with "start", which doesn’t do required command exit code check, it's better to do necessary check when writing pid and log files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira