You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2016/02/24 22:56:52 UTC
Review Request 43965: Move logic involving HBase shell calls to enable
normalization and FIFO compaction policy to Java code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43965/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-15170
https://issues.apache.org/jira/browse/AMBARI-15170
Repository: ambari
Description
-------
Currently, HBase shell calls are made through the metrics collector startup script in a parallel thread along with the Collector start jvm, causing performance issues. If the logic is moved to the collector Java code, we can return from the startup script quicker and declare the action to be Success to the agent once schema creating succeeds.
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector e319d73
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java b5ec6e8
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 1c86ebb
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultPhoenixDataSource.java 8283f7d
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java cd1bfb3
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java df4fc89
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 0522f81
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java 9838bca
Diff: https://reviews.apache.org/r/43965/diff/
Testing
-------
Unit test pass.
Manual test pass.
Thanks,
Sid Wagle
Re: Review Request 43965: Move logic involving HBase shell calls to
enable normalization and FIFO compaction policy to Java code
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43965/#review120588
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Feb. 24, 2016, 9:56 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43965/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:56 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15170
> https://issues.apache.org/jira/browse/AMBARI-15170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, HBase shell calls are made through the metrics collector startup script in a parallel thread along with the Collector start jvm, causing performance issues. If the logic is moved to the collector Java code, we can return from the startup script quicker and declare the action to be Success to the agent once schema creating succeeds.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector e319d73
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java b5ec6e8
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 1c86ebb
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultPhoenixDataSource.java 8283f7d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java cd1bfb3
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java df4fc89
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 0522f81
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java 9838bca
>
> Diff: https://reviews.apache.org/r/43965/diff/
>
>
> Testing
> -------
>
> Unit test pass.
> Manual test pass.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 43965: Move logic involving HBase shell calls to
enable normalization and FIFO compaction policy to Java code
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43965/#review120587
-----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector (line 307)
<https://reviews.apache.org/r/43965/#comment182058>
Delete these?
- Sumit Mohanty
On Feb. 24, 2016, 9:56 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43965/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:56 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15170
> https://issues.apache.org/jira/browse/AMBARI-15170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, HBase shell calls are made through the metrics collector startup script in a parallel thread along with the Collector start jvm, causing performance issues. If the logic is moved to the collector Java code, we can return from the startup script quicker and declare the action to be Success to the agent once schema creating succeeds.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector e319d73
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java b5ec6e8
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 1c86ebb
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultPhoenixDataSource.java 8283f7d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java cd1bfb3
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java df4fc89
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 0522f81
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java 9838bca
>
> Diff: https://reviews.apache.org/r/43965/diff/
>
>
> Testing
> -------
>
> Unit test pass.
> Manual test pass.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 43965: Move logic involving HBase shell calls to
enable normalization and FIFO compaction policy to Java code
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43965/#review120590
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On Feb. 24, 2016, 9:56 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43965/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:56 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15170
> https://issues.apache.org/jira/browse/AMBARI-15170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, HBase shell calls are made through the metrics collector startup script in a parallel thread along with the Collector start jvm, causing performance issues. If the logic is moved to the collector Java code, we can return from the startup script quicker and declare the action to be Success to the agent once schema creating succeeds.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector e319d73
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java b5ec6e8
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 1c86ebb
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultPhoenixDataSource.java 8283f7d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixConnectionProvider.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java cd1bfb3
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java df4fc89
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 0522f81
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java 9838bca
>
> Diff: https://reviews.apache.org/r/43965/diff/
>
>
> Testing
> -------
>
> Unit test pass.
> Manual test pass.
>
>
> Thanks,
>
> Sid Wagle
>
>