[jira] [Updated] (PHOENIX-1987) SIGN built-in function should be order preserving

["Shuxiong Ye (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shuxiong Ye updated PHOENIX-1987:
---------------------------------
    Attachment: 0001-PHOENIX-1987-SIGN-built-in-function-should-be-order-.patch

Hi [~jamestaylor], Sorry for late reply, I am busy these days.

This patch contains:

1. add preservesOrder in SignFunction (always OrderPreserving.YES)
2. add getSortOrder in SignFunction (will be same with input SortOrder)
3. SortOrder of result in SignFunction will be same with input

> SIGN built-in function should be order preserving
> -------------------------------------------------
>
>                 Key: PHOENIX-1987
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1987
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Shuxiong Ye
>         Attachments: 0001-PHOENIX-1987-SIGN-built-in-function-should-be-order-.patch
>
>
> The SIGN built-in function preserves the order of its input. This needs to be explicitly implemented in SignFunction by implementing the following method:
> {code}
>     public OrderPreserving preservesOrder() {
>         return OrderPreserving.YES;
>     }
> {code}
> This will allow certain optimizations reducing the amount of memory and/or buffering that is required if SIGN is used in a GROUP BY or ORDER BY clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)