You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/02/20 03:20:27 UTC
[GitHub] [airflow] amoghrajesh opened a new issue, #29621: Fix adding annotations for dag persistence PVC
amoghrajesh opened a new issue, #29621:
URL: https://github.com/apache/airflow/issues/29621
### Official Helm Chart version
1.8.0 (latest released)
### Apache Airflow version
2.5.0
### Kubernetes Version
v1.25.4
### Helm Chart configuration
The dags persistence section doesn't have a default value for annotations and the usage looks like:
```
annotations:
{{- if .Values.dags.persistence.annotations}}
{{- toYaml .Values.dags.persistence.annotations | nindent 4 }}
{{- end }}
```
### Docker Image customizations
_No response_
### What happened
As per the review comments here: https://github.com/apache/airflow/pull/29270#pullrequestreview-1304890651, due to this design, the upgrades might suffer. Fix them to be helm upgrade friendly
### What you think should happen instead
The design should be written in an helm upgrade friendly way, refer to this suggestion https://github.com/apache/airflow/pull/29270#pullrequestreview-1304890651
### How to reproduce
-
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on issue #29621: Fix adding annotations for dag persistence PVC
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on issue #29621:
URL: https://github.com/apache/airflow/issues/29621#issuecomment-1437660008
@potiuk we can close it since #29622 is megred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #29621: Fix adding annotations for dag persistence PVC
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29621:
URL: https://github.com/apache/airflow/issues/29621#issuecomment-1437926047
For the future @amoghrajesh -> please remember to add description and ("Fixes: #PR) outside of the comment section so that the issues get closed automatically when PR is merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #29621: Fix adding annotations for dag persistence PVC
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #29621:
URL: https://github.com/apache/airflow/issues/29621#issuecomment-1437873701
@potiuk we can close this issue. The PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #29621: Fix adding annotations for dag persistence PVC
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29621:
URL: https://github.com/apache/airflow/issues/29621#issuecomment-1437596195
Feel free to fix them @amoghrajesh . Assigned you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #29621: Fix adding annotations for dag persistence PVC
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #29621:
URL: https://github.com/apache/airflow/issues/29621#issuecomment-1436259360
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #29621: Fix adding annotations for dag persistence PVC
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #29621: Fix adding annotations for dag persistence PVC
URL: https://github.com/apache/airflow/issues/29621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org