You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by pgbhagat <gi...@git.apache.org> on 2018/02/19 10:12:14 UTC
[GitHub] cassandra pull request #196: Fixes
GitHub user pgbhagat opened a pull request:
https://github.com/apache/cassandra/pull/196
Fixes
Avoiding string concat in for loop.
Fixing null pointer exception in CoalescingStrategies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pgbhagat/cassandra trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit 5ac566ffc9739a8d9612acb23a089897e3168f8a
Author: Prashant Bhagat <pg...@...>
Date: 2018-02-19T10:11:08Z
Fixes
Avoiding string concat in for loop.
Fixing null pointer exception in CoalescingStrategies
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #196: Fixes
Posted by pgbhagat <gi...@git.apache.org>.
Github user pgbhagat commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/196#discussion_r170411576
--- Diff: test/unit/org/apache/cassandra/io/util/NIODataInputStreamTest.java ---
@@ -97,7 +97,7 @@ public void close() throws IOException {}
@Override
public boolean isOpen()
{
- return isOpen();
--- End diff --
Originally was an infinite loop. Fixing it
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #196: Fixes
Posted by pgbhagat <gi...@git.apache.org>.
Github user pgbhagat commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/196#discussion_r169031629
--- Diff: src/java/org/apache/cassandra/utils/CoalescingStrategies.java ---
@@ -146,7 +146,7 @@ protected AbstractCoalescingStrategy(Logger logger, String displayName)
{
File outFile = File.createTempFile("coalescing_" + this.displayName + "_", ".log", new File(DEBUG_COALESCING_PATH));
rasTemp = new RandomAccessFile(outFile, "rw");
- logBufferTemp = ras.getChannel().map(MapMode.READ_WRITE, 0, Integer.MAX_VALUE);
--- End diff --
At this line, ras is null, replacing it with rasTemp.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org