You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/08/17 02:41:54 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang opened a new pull request #678: rbac frame pkg should not import un necessary pkg

tianxiaoliang opened a new pull request #678:
URL: https://github.com/apache/servicecomb-service-center/pull/678


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #678: rbac frame pkg should not import un necessary pkg

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #678:
URL: https://github.com/apache/servicecomb-service-center/pull/678#discussion_r471207817



##########
File path: pkg/rbacframe/api_test.go
##########
@@ -49,8 +49,8 @@ func TestMustAuth(t *testing.T) {
 	rbacframe.Add2WhiteAPIList("/test")
 	assert.False(t, rbacframe.MustAuth("/test"))
 	assert.True(t, rbacframe.MustAuth("/auth"))
-	assert.False(t, rbacframe.MustAuth("/version"))
-	assert.False(t, rbacframe.MustAuth("/v4/a/registry/health"))
+	assert.True(t, rbacframe.MustAuth("/version"))

Review comment:
       没有增加这个白名单，所以的确是true




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] humingcheng commented on a change in pull request #678: rbac frame pkg should not import un necessary pkg

Posted by GitBox <gi...@apache.org>.
humingcheng commented on a change in pull request #678:
URL: https://github.com/apache/servicecomb-service-center/pull/678#discussion_r471205649



##########
File path: pkg/rbacframe/api_test.go
##########
@@ -49,8 +49,8 @@ func TestMustAuth(t *testing.T) {
 	rbacframe.Add2WhiteAPIList("/test")
 	assert.False(t, rbacframe.MustAuth("/test"))
 	assert.True(t, rbacframe.MustAuth("/auth"))
-	assert.False(t, rbacframe.MustAuth("/version"))
-	assert.False(t, rbacframe.MustAuth("/v4/a/registry/health"))
+	assert.True(t, rbacframe.MustAuth("/version"))

Review comment:
       应该是false




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #678: rbac frame pkg should not import un necessary pkg

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #678:
URL: https://github.com/apache/servicecomb-service-center/pull/678


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org