[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4690: [TE] Fix ignored timeout by checking Thread.interrupted

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4690: [TE] Fix ignored timeout by checking Thread.interrupted
URL: https://github.com/apache/incubator-pinot/pull/4690#discussion_r333777298
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java
 ##########
 @@ -249,6 +249,12 @@ public DetectionPipelineResult run() throws Exception {
       checkEarlyStop(totalNestedMetrics, successNestedMetrics, i, lastException);
       MetricEntity metric = nestedMetrics.get(i);
       try {
+        if (Thread.interrupted()) {
 
 Review comment:
   Please also add more context like below "Detection with multiple dimensions may take a significantly long time, which would be cancelled from TaskDriver."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org