You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2025/04/02 14:13:30 UTC
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22721
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
BINARY data in text files are expected to be Base64 encoded.
TextConverter::WriteSlot has a bug when it decodes base64 code,
it does not set the NULL-indicator bit to NULL for the slots of
the invalid BINARY values. Therefore later Tuple::CopyStrings can
try to copy invalid StringValue objects.
This patch fixes TextConverter::WriteSlot to set the NULL-indicator
bit in case of Base64 parse errors.
Testing
* e2e test added
Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
---
M be/src/exec/text-converter.inline.h
M testdata/data/README
A testdata/data/invalid_binary_data.txt
A testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
M tests/data_errors/test_data_errors.py
5 files changed, 110 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/22721/1
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 2:
(2 comments)
thanks for fixing this, looks good, only found a duplicate test
http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h
File be/src/exec/text-converter.inline.h:
http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h@105
PS2, Line 105: parse_result = StringParser::PARSE_FAILURE;
: break;
optional: it would be clearer to extract the string parsing switch part of the function into an inline function that could return a bool or StringParser::ParseResult
http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
File testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test:
http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test@29
PS2, Line 29: SELECT * FROM invalid_binary;
This is the same as the first query in the test.
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 14:24:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/18798/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 14:43:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11690/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Apr 2025 08:30:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11687/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 19:17:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/18797/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 14:41:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 17:05:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
BINARY data in text files are expected to be Base64 encoded.
TextConverter::WriteSlot has a bug when it decodes base64 code,
it does not set the NULL-indicator bit to NULL for the slots of
the invalid BINARY values. Therefore later Tuple::CopyStrings can
try to copy invalid StringValue objects.
This patch fixes TextConverter::WriteSlot to set the NULL-indicator
bit in case of Base64 parse errors.
Testing
* e2e test added
Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
---
M be/src/exec/text-converter.inline.h
M testdata/data/README
A testdata/data/invalid_binary_data.txt
A testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
M tests/data_errors/test_data_errors.py
5 files changed, 110 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/22721/2
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Apr 2025 08:30:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11687/
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Apr 2025 05:17:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22721
to look at the new patch set (#3).
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
BINARY data in text files are expected to be Base64 encoded.
TextConverter::WriteSlot has a bug when it decodes base64 code,
it does not set the NULL-indicator bit to NULL for the slots of
the invalid BINARY values. Therefore later Tuple::CopyStrings can
try to copy invalid StringValue objects.
This patch fixes TextConverter::WriteSlot to set the NULL-indicator
bit in case of Base64 parse errors.
Testing
* e2e test added
Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
---
M be/src/exec/text-converter.inline.h
M bin/rat_exclude_files.txt
M testdata/data/README
A testdata/data/invalid_binary_data.txt
A testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
M tests/data_errors/test_data_errors.py
6 files changed, 98 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/22721/3
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
BINARY data in text files are expected to be Base64 encoded.
TextConverter::WriteSlot has a bug when it decodes base64 code,
it does not set the NULL-indicator bit to NULL for the slots of
the invalid BINARY values. Therefore later Tuple::CopyStrings can
try to copy invalid StringValue objects.
This patch fixes TextConverter::WriteSlot to set the NULL-indicator
bit in case of Base64 parse errors.
Testing
* e2e test added
Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Reviewed-on: http://gerrit.cloudera.org:8080/22721
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/text-converter.inline.h
M bin/rat_exclude_files.txt
M testdata/data/README
A testdata/data/invalid_binary_data.txt
A testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
M tests/data_errors/test_data_errors.py
6 files changed, 98 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 17:28:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Apr 2025 13:57:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18799/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 16:31:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
Patch Set 3:
(2 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h
File be/src/exec/text-converter.inline.h:
http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h@105
PS2, Line 105: parse_result = StringParser::PARSE_FAILURE;
: break;
> optional: it would be clearer to extract the string parsing switch part of
It should be possible, but we also need to keep WriteSlot() in sync with CodegenWriteSlot(), so I rather not change too many things here to keep the implementations similar.
CodegenWriteSlot() is not supported for BINARY, so this change doesn't require changing CodegenWriteSlot().
http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
File testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test:
http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test@29
PS2, Line 29: SELECT id, bindata FROM inval
> This is the same as the first query in the test.
Removed
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 16:04:29 +0000
Gerrit-HasComments: Yes