You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/20 23:40:59 UTC

[GitHub] [camel-website] Gunkev opened a new pull request #248: reduce font size in frontpage section and redesign button

Gunkev opened a new pull request #248: reduce font size in frontpage section and redesign button
URL: https://github.com/apache/camel-website/pull/248
 
 
   In this PR I reduce the front page h1 font size and button since it was do extremely big 
   
   # Original Camel website
   
   ![Screenshot from 2020-03-21 00-16-53](https://user-images.githubusercontent.com/36812576/77213827-91e98000-6b0c-11ea-9f79-213caf7bf935.png)
   
   
   
   # Changes made
   
   ![Screenshot from 2020-03-21 00-35-38](https://user-images.githubusercontent.com/36812576/77213824-8e55f900-6b0c-11ea-8e72-4090fea3fb18.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev closed pull request #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

Gunkev closed pull request #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

zregvart commented on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-604409507
 
 
   @Gunkev I understand that you think that the font size is too big. I think this is quite a common design pattern used today, have a look at some examples like: [Bootstrap](https://getbootstrap.com/) or [ReactJS](https://reactjs.org/) or [Netlify](https://www.netlify.com).
   
   What I need from you is to argument why this needs to change, citing some design or usability reasons backed up with references, rather than to explain what changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev edited a comment on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

Gunkev edited a comment on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-603470836
 
 
   > Any reason why the font needs to be changed? To me what we have looks good. This needs to be rebased to pick up the changes we made recently to the de
   
   The font size seems to be too big on larger screen. Plus transition was added to the button

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev commented on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

Gunkev commented on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-605980157
 
 
   > @Gunkev are you still working on this?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev commented on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

Gunkev commented on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-603470836
 
 
   > Any reason why the font needs to be changed? To me what we have looks good. This needs to be rebased to pick up the changes we made recently to the de
   
   The font size seems to be tooo big on larger screen. Plsu transition was added to the button

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev edited a comment on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

Gunkev edited a comment on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-603470836
 
 
   > Any reason why the font needs to be changed? To me what we have looks good. This needs to be rebased to pick up the changes we made recently to the de
   
   The font size seems to be too big on larger screen. Plsu transition was added to the button

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] Gunkev closed pull request #248: reduce font size in frontpage section and redesign button

Posted by GitBox <gi...@apache.org>.

Gunkev closed pull request #248: reduce font size in frontpage section and redesign button
URL: https://github.com/apache/camel-website/pull/248
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #248: reduce font size in frontpage section and button

Posted by GitBox <gi...@apache.org>.

zregvart commented on issue #248: reduce font size in frontpage section and button
URL: https://github.com/apache/camel-website/pull/248#issuecomment-605975594
 
 
   @Gunkev are you still working on this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services