You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/06 17:53:38 UTC
[GitHub] [incubator-mxnet] josephevans opened a new pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
josephevans opened a new pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492
Action item 1 from https://github.com/apache/incubator-mxnet/issues/20475.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492#issuecomment-894421282
Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, website, windows-cpu, unix-cpu, centos-cpu, clang, windows-gpu, centos-gpu, edge, miscellaneous, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492#discussion_r684514233
##########
File path: LICENSE
##########
@@ -310,12 +306,16 @@
python/mxnet/onnx/mx2onnx/_export_onnx.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
+ src/operator/numpy/np_einsum_op-inl.h
Review comment:
should we list functions of BSD clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492#discussion_r684550714
##########
File path: LICENSE
##########
@@ -310,12 +306,16 @@
python/mxnet/onnx/mx2onnx/_export_onnx.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
+ src/operator/numpy/np_einsum_op-inl.h
Review comment:
We also don't call out specific functions in other files in this LICENSE category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20492: [v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20492:
URL: https://github.com/apache/incubator-mxnet/pull/20492#discussion_r684550439
##########
File path: LICENSE
##########
@@ -310,12 +306,16 @@
python/mxnet/onnx/mx2onnx/_export_onnx.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
+ src/operator/numpy/np_einsum_op-inl.h
Review comment:
Based on the history of the file, it seems as if it was heavily modified, so I think we are correct to release it under ASF 2.0 license and don't need to call out specific functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org