You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/10 17:30:43 UTC
[GitHub] [incubator-hudi] satishkotha opened a new pull request #1392:
[HUDI-689] Change CLI command names to not have overlap
satishkotha opened a new pull request #1392: [HUDI-689] Change CLI command names to not have overlap
URL: https://github.com/apache/incubator-hudi/pull/1392
## What is the purpose of the pull request
I broke CLI when i added compactions show archived command.
I still dont understand spring shell well enough to explain why the existing commands wont work. But the alternative commands I picked seemed to work. Please let me know if any of you have seen similar issues with spring shell and how command parsing works.
CLI 'commits show archived' fails with
->commits show archived
Option '' is not available for this command. Use tab assist or the "help" command to see the legal options
This seems to be because 'compactions show archived'. If i remove @CliCommand annotation from compactions, commits show archived works.
## Brief change log
- Chose different command names to make all commands 'work'
- change method names to not overlap with each other
## Verify this pull request
Manually verified the change by running CLI
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on issue #1392: [HUDI-689]
Change CLI command names to not have overlap
Posted by GitBox <gi...@apache.org>.
bvaradar commented on issue #1392: [HUDI-689] Change CLI command names to not have overlap
URL: https://github.com/apache/incubator-hudi/pull/1392#issuecomment-597434910
@nsivabalan : Please review this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1392:
[HUDI-689] Change CLI command names to not have overlap
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1392: [HUDI-689] Change CLI command names to not have overlap
URL: https://github.com/apache/incubator-hudi/pull/1392#issuecomment-597241101
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=h1) Report
> Merging [#1392](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/77d5b92d88d6583bdfc09e4c10ecfe7ddbb04806&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1392 +/- ##
============================================
- Coverage 67.40% 67.37% -0.03%
Complexity 230 230
============================================
Files 336 336
Lines 16366 16366
Branches 1672 1672
============================================
- Hits 11031 11027 -4
Misses 4602 4602
- Partials 733 737 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | |
| [...a/org/apache/hudi/common/util/collection/Pair.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9QYWlyLmphdmE=) | `72.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `79.79% <0.00%> (-1.02%)` | `8.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=footer). Last update [77d5b92...c3f11b8](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1392: [HUDI-689]
Change CLI command names to not have overlap
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1392: [HUDI-689] Change CLI command names to not have overlap
URL: https://github.com/apache/incubator-hudi/pull/1392#issuecomment-597241101
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=h1) Report
> Merging [#1392](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/77d5b92d88d6583bdfc09e4c10ecfe7ddbb04806&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1392 +/- ##
============================================
- Coverage 67.40% 67.37% -0.03%
Complexity 230 230
============================================
Files 336 336
Lines 16366 16366
Branches 1672 1672
============================================
- Hits 11031 11027 -4
Misses 4602 4602
- Partials 733 737 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | |
| [...a/org/apache/hudi/common/util/collection/Pair.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9QYWlyLmphdmE=) | `72.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1392/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `79.79% <0.00%> (-1.02%)` | `8.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=footer). Last update [77d5b92...c3f11b8](https://codecov.io/gh/apache/incubator-hudi/pull/1392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar merged pull request #1392: [HUDI-689]
Change CLI command names to not have overlap
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1392: [HUDI-689] Change CLI command names to not have overlap
URL: https://github.com/apache/incubator-hudi/pull/1392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services