You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/26 02:43:48 UTC
[kudu-CR] [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18775
Change subject: [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
......................................................................
[c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
This patch adds more tests for Kudu C++ client covering the paths
involving CreateTable RPC for tables with unbounded ranges having custom
hash schemas.
Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
---
M src/kudu/client/flex_partitioning_client-test.cc
1 file changed, 91 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18775/3
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 10:22:50 +0000
Gerrit-HasComments: No
[kudu-CR] [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 13:56:00 +0000
Gerrit-HasComments: No
[kudu-CR] [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
......................................................................
Patch Set 3: Verified+1
unrelated test failure in HmsConfigurations/AlterTableRandomized.TestRandomSequence/0
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 05:45:53 +0000
Gerrit-HasComments: No
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 10:45:38 +0000
Gerrit-HasComments: No
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18775
to look at the new patch set (#4).
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
[c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
This patch adds more tests for Kudu C++ client covering the paths
involving CreateTable RPC for tables with unbounded ranges having custom
hash schemas.
Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
---
M src/kudu/client/flex_partitioning_client-test.cc
1 file changed, 91 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18775/4
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for ubounded ranges (CreateTable)
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18775/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18775/3//COMMIT_MSG@7
PS3, Line 7: ubounded
nit: unbounded
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 07:09:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18775/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18775/3//COMMIT_MSG@7
PS3, Line 7: ubounded
> nit: unbounded
Done
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 16:49:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 17:07:37 +0000
Gerrit-HasComments: No
[kudu-CR] [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18775 )
Change subject: [c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
......................................................................
[c++-client] KUDU-2671 more tests for unbounded ranges (CreateTable)
This patch adds more tests for Kudu C++ client covering the paths
involving CreateTable RPC for tables with unbounded ranges having custom
hash schemas.
Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Reviewed-on: http://gerrit.cloudera.org:8080/18775
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/client/flex_partitioning_client-test.cc
1 file changed, 91 insertions(+), 0 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I584f613ddf3341156d02c4e7c9603b71584cfcf4
Gerrit-Change-Number: 18775
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>