[GitHub] [spark] maropu commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression
URL: https://github.com/apache/spark/pull/26656#discussion_r354595927
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part3.sql
 ##########
 @@ -400,10 +400,10 @@ SELECT ntile(0) OVER (ORDER BY ten), ten, four FROM tenk1;
 -- filter
 
 -- [SPARK-28500] Adds support for `filter` clause
 
 Review comment:
   Pg supports this query. If jira for this issue doesn't exist in [the Pg feature parity ticket](https://issues.apache.org/jira/browse/SPARK-27764), can you file jira and update this comment?
   https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/window.out#L2989-L3000

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org