You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Jeffery Painter <je...@jivecast.com> on 2018/12/13 15:04:34 UTC
Turbine core tests failing
Hi guys,
Georg - I know you are making lots of updates to testcontainer and I am
trying to follow along to see how it impacts the other modules that rely
on it. As it is, turbine/core/trunk now fails to run any test cases.
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 5.689 s
[INFO] Finished at: 2018-12-13T09:59:42-05:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test
(default-test) on project turbine: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) -> [Help 1]
[ERROR]
I played with the pom.xml to try and get the tests back and running. I
had to add the jupiter dependencies from testcontainer/pom.xml and
update the surefire plugin the same as you had done there. Once that was
done however, I started getting a number of test failures.
One test in particular:
org.apache.turbine.services.avaloncomponent.TurbineAvalonComponentServiceTest#testGetAndUseTestComponent()
It looks like the test case is not loading the proper configuration
since when I inspect the service manager in the debugger, it looks like
it is pulling its configuration from
conf/test/fulcrumRoleConfigurationWithQuartz.xml as it had the Quartz
service in the service manager object.
I had updated fulcrum-quartz to play nicely with your updated
testcontainer, but it looks as a result all of the quartz/scheduler
tests are failing in turbine core. I did not dig into those yet. I just
removed them until I could figure out how to get the testing framework
to run at all (not a solution haha).
If you have a minute to check this out and make the pom changes needed
for turbine/core, that would be great. I don't want to add anything in
there that isn't really required. Meanwhile, I will just focus on
getting the fulcrum-yaafi release going.
Thanks!
--
Jeff Painter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
Antwort: Turbine core tests failing
Posted by Georg Kallidis <ge...@cedis.fu-berlin.de>.
Hi Jeffery,
yes, I have to check this, though the newest Eclipse does find and execute
tests, and probably IntelliJ as well, but maven console not. I 'll check
this.
It seems, that updating surefire to v3.0.0-M2 resolves it, changing this
in pom.xml:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M2</version>
<configuration>
<!--default setting is forkCount=1/reuseForks=true -->
<reuseForks>false</reuseForks>
<forkCount>1</forkCount>
</configuration>
<dependencies>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>5.3.1</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>5.3.1</version>
</dependency>
</dependencies>
</plugin>
The alternative mentioned in
https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven
keeping surefire to v2.22.0 did and adding the dep to vintage seems no
solution (it is added transitively via test-container.
Best regards, Georg
Von: Jeffery Painter <je...@jivecast.com>
An: Turbine Developers List <de...@turbine.apache.org>
Datum: 13.12.2018 16:04
Betreff: Turbine core tests failing
Hi guys,
Georg - I know you are making lots of updates to testcontainer and I am
trying to follow along to see how it impacts the other modules that rely
on it. As it is, turbine/core/trunk now fails to run any test cases.
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 5.689 s
[INFO] Finished at: 2018-12-13T09:59:42-05:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test
(default-test) on project turbine: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) -> [Help 1]
[ERROR]
I played with the pom.xml to try and get the tests back and running. I
had to add the jupiter dependencies from testcontainer/pom.xml and
update the surefire plugin the same as you had done there. Once that was
done however, I started getting a number of test failures.
One test in particular:
org.apache.turbine.services.avaloncomponent.TurbineAvalonComponentServiceTest#testGetAndUseTestComponent()
It looks like the test case is not loading the proper configuration
since when I inspect the service manager in the debugger, it looks like
it is pulling its configuration from
conf/test/fulcrumRoleConfigurationWithQuartz.xml as it had the Quartz
service in the service manager object.
I had updated fulcrum-quartz to play nicely with your updated
testcontainer, but it looks as a result all of the quartz/scheduler
tests are failing in turbine core. I did not dig into those yet. I just
removed them until I could figure out how to get the testing framework
to run at all (not a solution haha).
If you have a minute to check this out and make the pom changes needed
for turbine/core, that would be great. I don't want to add anything in
there that isn't really required. Meanwhile, I will just focus on
getting the fulcrum-yaafi release going.
Thanks!
--
Jeff Painter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org