You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by ka...@apache.org on 2010/06/17 12:52:38 UTC

svn commit: r955546 - in /db/derby/code/trunk/java: engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java

Author: kahatlen
Date: Thu Jun 17 10:52:37 2010
New Revision: 955546

URL: http://svn.apache.org/viewvc?rev=955546&view=rev
Log:
DERBY-462: DatabaseMetaData method supportsConvert() returns true

Return false since we don't support CONVERT.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java?rev=955546&r1=955545&r2=955546&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java Thu Jun 17 10:52:37 2010
@@ -566,7 +566,7 @@ public class EmbedDatabaseMetaData exten
      * @return true if so
      */
 	public boolean supportsConvert() {
-		return true;
+		return false;
 	}
 
     /**

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java?rev=955546&r1=955545&r2=955546&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java Thu Jun 17 10:52:37 2010
@@ -377,8 +377,7 @@ public class DatabaseMetaDataTest extend
         
         assertTrue(dmd.supportsColumnAliasing());
         
-        // Bug DERBY-462 should return false.
-        assertTrue(dmd.supportsConvert());
+        assertFalse(dmd.supportsConvert());
         // Simple check since convert is not supported.
         // A comprehensive test should be added when convert
         // is supported, though most likely in a test class