[GitHub] [spark] dbtsai commented on a change in pull request #24865: [SPARK-27100][SQL] dag-scheduler-event-loop" java.lang.StackOverflowError

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #24865: [SPARK-27100][SQL] dag-scheduler-event-loop" java.lang.StackOverflowError
URL: https://github.com/apache/spark/pull/24865#discussion_r294404215
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
 ##########
 @@ -381,7 +381,7 @@ case class FileSourceScanExec(
       fsRelation: HadoopFsRelation): RDD[InternalRow] = {
     logInfo(s"Planning with ${bucketSpec.numBuckets} buckets")
     val filesGroupedToBuckets =
-      selectedPartitions.flatMap { p =>
+      selectedPartitions.toArray.flatMap { p =>
 
 Review comment:
   `@transient private lazy val selectedPartitions: Seq[PartitionDirectory]` is returning type of `Seq`. Since it's `lazy val` and used many times in the life cycle, why not we make it `@transient private lazy val selectedPartitions: Array[PartitionDirectory]`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org