[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #298: Add some checks for HadoopTables#create

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #298: Add some checks for HadoopTables#create
URL: https://github.com/apache/incubator-iceberg/pull/298#discussion_r305509896
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
 ##########
 @@ -70,18 +72,23 @@ public Table load(String location) {
    *
    * @param schema iceberg schema used to create the table
    * @param spec partition specification
+   * @param properties properties of the table to be created
 
 Review comment:
   Can you note that null is accepted?
   
   Also, should we do something similar for spec? If spec is null, we could use `PartitionSpec.unpartitioned()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org