You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/18 00:20:08 UTC

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4994: Make sql as default query format.

fx19880617 commented on a change in pull request #4994: Make sql as default query format.
URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368186639
 
 

 ##########
 File path: pinot-controller/src/main/resources/static/query/index.html
 ##########
 @@ -79,11 +79,11 @@ <h1><a href="#/">Pinot Data Explorer</a></h1>
           <div class="small-2 columns" title="Enables tracing">
             <input type=checkbox id="trace-enabled">&nbsp;&nbsp;Tracing</input>
           </div>
-          <div class="small-3 columns" title="Sets groupByMode=sql in queryOptions (default pql)">
 
 Review comment:
   changed the ui to only show one check box of pql, which means to use pql syntax if checked.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org