[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6656: [Fix-#6641]fix npe when the LowerWeightHostManager can not get the workNodeInfo

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6656:
URL: https://github.com/apache/dolphinscheduler/pull/6656#discussion_r743381191



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/LowerWeightHostManager.java
##########
@@ -154,6 +155,11 @@ public void run() {
         }
 
         public HostWeight getHostWeight(String addr, String workerGroup, String heartBeatInfo) {
+            if (StringUtils.isEmpty(heartBeatInfo)) {

Review comment:
       Maybe we can change the return type of `org.apache.dolphinscheduler.server.master.registry.ServerNodeManager#getWorkerNodeInfo(java.lang.String)` to `Optional<String>` and check whether it's `Optional.isPresent()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org