You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org> on 2023/08/09 19:39:56 UTC
[GitHub] [cassandra-website] ekaterinadimitrova2 opened a new pull request, #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
ekaterinadimitrova2 opened a new pull request, #233:
URL: https://github.com/apache/cassandra-website/pull/233
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ekaterinadimitrova2 closed pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 closed pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
URL: https://github.com/apache/cassandra-website/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ekaterinadimitrova2 commented on a diff in pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #233:
URL: https://github.com/apache/cassandra-website/pull/233#discussion_r1290226039
##########
site-content/source/modules/ROOT/pages/development/how_to_commit.adoc:
##########
@@ -14,35 +14,43 @@ Hypothetical CASSANDRA-12345 ticket is a cassandra-4.0 based bug fix
that requires different code for cassandra-4.0, cassandra-4.1, and
trunk. Contributor Jackie supplied a patch for the root branch
(12345-4.0.patch), and patches for the remaining branches
-(12345-4.1.patch, 12345-trunk.patch).
+(12345-4.1.patch, 12345-5.0.patch, 12345-trunk.patch).
On cassandra-4.0:::
. `+git am -3 12345-4.0.patch+` (any problem b/c of CHANGES.txt not
merging anymore, fix it in place)
- . `+ant realclean && ant jar build-test+` (rebuild to make sure code
+ . `+ant realclean && ant jar build-test check+` (rebuild to make sure code
Review Comment:
Actually I just realized I made a mistake, check should be added only for the 5.0 and trunk branches.
I will remove build-test, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ekaterinadimitrova2 commented on a diff in pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #233:
URL: https://github.com/apache/cassandra-website/pull/233#discussion_r1290226039
##########
site-content/source/modules/ROOT/pages/development/how_to_commit.adoc:
##########
@@ -14,35 +14,43 @@ Hypothetical CASSANDRA-12345 ticket is a cassandra-4.0 based bug fix
that requires different code for cassandra-4.0, cassandra-4.1, and
trunk. Contributor Jackie supplied a patch for the root branch
(12345-4.0.patch), and patches for the remaining branches
-(12345-4.1.patch, 12345-trunk.patch).
+(12345-4.1.patch, 12345-5.0.patch, 12345-trunk.patch).
On cassandra-4.0:::
. `+git am -3 12345-4.0.patch+` (any problem b/c of CHANGES.txt not
merging anymore, fix it in place)
- . `+ant realclean && ant jar build-test+` (rebuild to make sure code
+ . `+ant realclean && ant jar build-test check+` (rebuild to make sure code
Review Comment:
Actually I just realized I made a mistake, `check` should be added only for the 5.0 and trunk branches.
I will remove `build-test`, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] ekaterinadimitrova2 commented on pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on PR #233:
URL: https://github.com/apache/cassandra-website/pull/233#issuecomment-1677624873
Committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #233: Update How to commit page post CASSANDRA-18618 and 5.0 branch creation
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #233:
URL: https://github.com/apache/cassandra-website/pull/233#discussion_r1289719701
##########
site-content/source/modules/ROOT/pages/development/how_to_commit.adoc:
##########
@@ -14,35 +14,43 @@ Hypothetical CASSANDRA-12345 ticket is a cassandra-4.0 based bug fix
that requires different code for cassandra-4.0, cassandra-4.1, and
trunk. Contributor Jackie supplied a patch for the root branch
(12345-4.0.patch), and patches for the remaining branches
-(12345-4.1.patch, 12345-trunk.patch).
+(12345-4.1.patch, 12345-5.0.patch, 12345-trunk.patch).
On cassandra-4.0:::
. `+git am -3 12345-4.0.patch+` (any problem b/c of CHANGES.txt not
merging anymore, fix it in place)
- . `+ant realclean && ant jar build-test+` (rebuild to make sure code
+ . `+ant realclean && ant jar build-test check+` (rebuild to make sure code
Review Comment:
all of the occurrences of `jar build-test` are superfluous, as jar already calls build-test
i.e. these can all be `ant realclean && ant jar check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org