You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by scotte <gi...@git.apache.org> on 2013/03/11 18:33:19 UTC

jmeter pull request: Add flag forcing non-GUI JVM to exit after test

GitHub user scotte opened a pull request:

    https://github.com/apache/jmeter/pull/3

    Add flag forcing non-GUI JVM to exit after test

    This is useful for cases when JMeter is run by an automated system
    (such as CI builds) and tests start threads that prevent the JVM
    from cleanly shutting down. The existing property to do a full JVM
    shutdown (jmeterengine.stopfail.system.exit) only executes when the
    test is explicitly asked to stop. We needed to unconditionally insure
    the JVM is terminated when the test was finished, even if the tests
    themselves did things which left the JVM in a state where JMeter could
    not cleanly exit in non-GUI mode.
    
    The new flag is "jmeterengine.force.system.exit" and defaults to
    "false".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scotte/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/3.patch

----
commit 787ad9666d39ca9d2ffb05973d28d4fc88d6cc0c
Author: Scott Emmons <se...@netflix.com>
Date:   2013-03-11T17:24:22Z

    Add flag forcing non-GUI JVM to exit after test
    
    This is useful for cases when JMeter is run by an automated system
    (such as CI builds) and tests start threads that prevent the JVM
    from cleanly shutting down. The existing property to do a full JVM
    shutdown (jmeterengine.stopfail.system.exit) only executes when the
    test is explicitly asked to stop. We needed to unconditionally insure
    the JVM is terminated when the test was finished, even if the tests
    themselves did things which left the JVM in a state where JMeter could
    not cleanly exit in non-GUI mode.
    
    The new flag is "jmeterengine.force.system.exit" and defaults to
    "false".

----


Re: jmeter pull request: Add flag forcing non-GUI JVM to exit after test

Posted by sebb <se...@gmail.com>.
On 11 March 2013 17:33, scotte <gi...@git.apache.org> wrote:
> GitHub user scotte opened a pull request:
>
>     https://github.com/apache/jmeter/pull/3

Thanks. Looksuseful.

We prefer patches/enhancements etc. to be submitted via the JMeter
issue tracking system, Bugzilla, so I have created

https://issues.apache.org/bugzilla/show_bug.cgi?id=54669

with the details. It's much easier to keep track of oustanding issues that way.

In future, please use Bugzilla for such patches/enhancement requests.

The mailing lists are better suited to discussions.

Thanks.