[PR] HDDS-10304. [DiskBalancer] Start command - Fix nodes not being processed and incorrect config values [ozone]

["sodonnel (via GitHub)" <gi...@apache.org>]

sodonnel opened a new pull request, #6181:
URL: https://github.com/apache/ozone/pull/6181

   ## What changes were proposed in this pull request?
   
   Fix various problems with the disk balancer start command:
   
   1. When using -a for all datanodes, the hosts appear as an empty list due to the way the protobuf is deserialized, resulting in no hosts getting processed.
   
   2. All the config values appear at zero, as if the proto value is not set for a double, it returns 0.0, so we need to check for has<field> and set an optional or empty
   
   3. The isHealthy check needed negated, as it was excluding healthy nodes rather than unhealthy ones resulting in no nodes getting processed.
   
   I also added a log message or two so we can have a record in the SCM log of the command being sent.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-10304
   
   ## How was this patch tested?
   
   Manually using docker compose. Prior to these changes the command would fail silently, but now SCM sends the command to the datanode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-10304. [DiskBalancer] Start command - Fix nodes not being processed and incorrect config values [ozone]

["sodonnel (via GitHub)" <gi...@apache.org>]

sodonnel merged PR #6181:
URL: https://github.com/apache/ozone/pull/6181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org