You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 14:43:44 UTC

[GitHub] [flink] wangyang0918 commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup

wangyang0918 commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615284603
 
 
   The changes looks good to me. I agree with @TisonKun that we need to add a new test, which will fails before the changes and pass after it. 
   For the test, i think we could have the following assumption.
   * The `port` of rest service should be equal to `rest.port`.
   * The `targetPort` should be equal to `rest.bind-port`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services