[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7815: debian: bundle in mysql connector python that may not be in distro

["rohityadavcloud (via GitHub)" <gi...@apache.org>]

rohityadavcloud commented on code in PR #7815:
URL: https://github.com/apache/cloudstack/pull/7815#discussion_r1284210501


##########
debian/cloudstack-management.postinst:
##########
@@ -59,6 +59,9 @@ if [ "$1" = configure ]; then
 
     ln -sf ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
 
+    # install mysql_connector_python
+    pip3 install /usr/share/cloudstack-management/setup/wheel/six-1.15.0-py2.py3-none-any.whl /usr/share/cloudstack-management/setup/wheel/setuptools-47.3.1-py3-none-any.whl /usr/share/cloudstack-management/setup/wheel/protobuf-3.19.6-py2.py3-none-any.whl /usr/share/cloudstack-management/setup/wheel/mysql_connector_python-8.0.31-py2.py3-none-any.whl

Review Comment:
   Same logic as in https://github.com/apache/cloudstack/blob/main/packaging/centos8/cloud.spec#L310



##########
debian/rules:
##########
@@ -84,6 +84,13 @@ override_dh_auto_install:
 	cp -r engine/schema/dist/systemvm-templates/* $(DESTDIR)/usr/share/$(PACKAGE)-management/templates/systemvm/
 	rm -rf $(DESTDIR)/usr/share/$(PACKAGE)-management/templates/systemvm/md5sum.txt
 
+	# Bundle in mysql_connector_python

Review Comment:
   Same logic as in https://github.com/apache/cloudstack/blob/main/packaging/centos8/cloud.spec#L310



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org