You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "omavashia2005 (via GitHub)" <gi...@apache.org> on 2026/10/19 03:45:07 UTC
[PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
omavashia2005 opened a new pull request, #9020:
URL: https://github.com/apache/texera/pull/9020
### What changes were proposed in this PR?
`bin/frontend-proto-gen.sh` runs `protoc` on `workflow.proto` and `virtualidentity.proto`, but ts-proto also writes TypeScript for their transitive imports. Those imports are used only for ScalaPB options (`scalapb.options`, `scalapb.field`), which shape the Scala output and produce no TypeScript types. As a result, two files nothing uses were generated and committed:
| File | Lines | Imported by |
| --- | --- | --- |
| `proto/google/protobuf/descriptor.ts` | 6824 | `scalapb.ts` only |
| `proto/scalapb/scalapb.ts` | 2394 | nothing |
Changes:
| File | Change |
| --- | --- |
| `bin/frontend-proto-gen.sh` | Removes `proto/scalapb` and `proto/google` after `protoc` runs, so the files don't come back on the next regeneration |
| `frontend/src/app/common/type/proto/{google,scalapb}/` | Deleted |
| `LICENSE` | Removes the `descriptor.ts` entry and the `scalapb.ts` line. The `scalapb.proto` entry stays because that file is still in the repo |
| `.licenserc.yaml` | Removes the license-check exclusions for the two deleted files |
```
Before: protoc -> workflow.ts, virtualidentity.ts, scalapb.ts, descriptor.ts (committed, unused)
After: protoc -> workflow.ts, virtualidentity.ts
```
User-facing behavior is unchanged.
### Any related issues, documentation, discussions?
Closes #N
Follows #9010, which added the `LICENSE` entries for these generated files.
### How was this PR tested?
- `bash bin/frontend-proto-gen.sh`: the output folder contains only `org/apache/texera/amber/core/{virtualidentity,workflow}.ts`
- `cd frontend && yarn build`: succeeds
- `cd frontend && yarn test`: 237 test files passed; 6649 tests passed, 1 skipped
No tests added: this removes dead generated code and nothing imports it.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored by Claude-Code (helped with file and code deletion, navigating repo, writing this PR description, and tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9020:
URL: https://github.com/apache/texera/pull/9020#issuecomment-6279571080
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/9020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.33%. Comparing base ([`a46ddc6`](https://app.codecov.io/gh/apache/texera/commit/a46ddc6eb6588491eb72b27bc975f060c4cb1a75?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`285661a`](https://app.codecov.io/gh/apache/texera/commit/285661a5160eb6a1f7dc2d1a5e5c007efe626f81?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9020 +/- ##
============================================
- Coverage 92.33% 92.33% -0.01%
Complexity 5045 5045
============================================
Files 1261 1261
Lines 54120 54120
Branches 6768 6768
============================================
- Hits 49970 49969 -1
Misses 2488 2488
- Partials 1662 1663 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.31% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.00% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.55% <ø> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.51% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/9020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (ø)` | | Carriedforward from [57d887c](https://app.codecov.io/gh/apache/texera/commit/57d887cee7fe111a85ed16b9f0e3f8fc69456616?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/9020?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "omavashia2005 (via GitHub)" <gi...@apache.org>.
omavashia2005 commented on code in PR #9020:
URL: https://github.com/apache/texera/pull/9020#discussion_r4310932297
##########
bin/frontend-proto-gen.sh:
##########
@@ -28,4 +28,8 @@ protoc --plugin="$GUI_DIR/node_modules/.bin/protoc-gen-ts_proto" \
-I="$PROTOBUF_DIR" \
"$WORKFLOW_PROTO" \
"$VIRTUALIDENTITY_PROTO" \
- --proto_path="$PROTOBUF_DIR"
\ No newline at end of file
+ --proto_path="$PROTOBUF_DIR"
+
+# ts-proto also emits TypeScript for the imports used only for ScalaPB options
+# (scalapb.proto and its descriptor.proto); nothing imports it, so drop it.
+rm -rf "$GUI_PROTO_DIR/proto/scalapb" "$GUI_PROTO_DIR/proto/google"
Review Comment:
Yeah wanted some feedback here, was a bit doubtful about having an rm rf command - can remove it if that's a better solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "omavashia2005 (via GitHub)" <gi...@apache.org>.
omavashia2005 commented on PR #9020:
URL: https://github.com/apache/texera/pull/9020#issuecomment-6275878980
@aglinxinyuan let me know if this is ok. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #9020:
URL: https://github.com/apache/texera/pull/9020#discussion_r4318931666
##########
bin/frontend-proto-gen.sh:
##########
@@ -28,4 +28,5 @@ protoc --plugin="$GUI_DIR/node_modules/.bin/protoc-gen-ts_proto" \
-I="$PROTOBUF_DIR" \
"$WORKFLOW_PROTO" \
"$VIRTUALIDENTITY_PROTO" \
- --proto_path="$PROTOBUF_DIR"
\ No newline at end of file
+ --proto_path="$PROTOBUF_DIR"
+
Review Comment:
Remove the empty change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9020:
URL: https://github.com/apache/texera/pull/9020#issuecomment-6259301157
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`, `@aglinxinyuan`
You can notify them by mentioning `@mengw15`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "omavashia2005 (via GitHub)" <gi...@apache.org>.
omavashia2005 commented on PR #9020:
URL: https://github.com/apache/texera/pull/9020#issuecomment-6259397839
Hey @mengw15 and @aglinxinyuan - would love to get feedback & get this merged. Do lmk if any changes are needed on my end. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #9020:
URL: https://github.com/apache/texera/pull/9020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "omavashia2005 (via GitHub)" <gi...@apache.org>.
omavashia2005 commented on code in PR #9020:
URL: https://github.com/apache/texera/pull/9020#discussion_r4319510948
##########
bin/frontend-proto-gen.sh:
##########
@@ -28,4 +28,5 @@ protoc --plugin="$GUI_DIR/node_modules/.bin/protoc-gen-ts_proto" \
-I="$PROTOBUF_DIR" \
"$WORKFLOW_PROTO" \
"$VIRTUALIDENTITY_PROTO" \
- --proto_path="$PROTOBUF_DIR"
\ No newline at end of file
+ --proto_path="$PROTOBUF_DIR"
+
Review Comment:
@aglinxinyuan done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #9020:
URL: https://github.com/apache/texera/pull/9020#discussion_r4310892504
##########
bin/frontend-proto-gen.sh:
##########
@@ -28,4 +28,8 @@ protoc --plugin="$GUI_DIR/node_modules/.bin/protoc-gen-ts_proto" \
-I="$PROTOBUF_DIR" \
"$WORKFLOW_PROTO" \
"$VIRTUALIDENTITY_PROTO" \
- --proto_path="$PROTOBUF_DIR"
\ No newline at end of file
+ --proto_path="$PROTOBUF_DIR"
+
+# ts-proto also emits TypeScript for the imports used only for ScalaPB options
+# (scalapb.proto and its descriptor.proto); nothing imports it, so drop it.
+rm -rf "$GUI_PROTO_DIR/proto/scalapb" "$GUI_PROTO_DIR/proto/google"
Review Comment:
This change is debatable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): drop unused generated protobuf TypeScript [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9020:
URL: https://github.com/apache/texera/pull/9020#issuecomment-6259317219
<!-- texera:welcome-first-time-contributor -->
👋 Thanks for your first contribution to Texera, @omavashia2005!
If you're looking for a good place to start, browse issues labeled [`starter-task`](https://github.com/apache/texera/issues?q=is%3Aissue+is%3Aopen+label%3Astarter-task); they're scoped to be approachable for newcomers.
You can drive common housekeeping yourself by commenting one of these commands on its own line:
- **Issues.** Comment `/take` to assign an open issue to yourself, or `/untake` to release it. You can find unclaimed work with the search filter `is:issue is:open no:assignee`.
- **Sub-issues.** To link issues into a parent/child hierarchy, comment `/sub-issue #5166 #5222` on the parent to attach those children (or `/unsub-issue #5166 #5222` to detach them). From a child issue, comment `/parent-issue #5166` to set its parent, or `/unparent-issue` to clear it (the current parent is detected automatically). References may be written as `#5166` or as a bare `5166`; cross-repository references are not supported.
- **Pull requests (author only).** Comment `/request-review @user` to request a review from someone, or `/unrequest-review @user` to withdraw that request.
Each command must match exactly: `/take this` will not work, only `/take` does. For the full contribution flow, see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org