Re: [PR] SOLR-17864: Migrate System Properties (part ocho) [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #3625:
URL: https://github.com/apache/solr/pull/3625#discussion_r2328832105


##########
solr/bin/solr.in.cmd:
##########
@@ -127,7 +127,7 @@ REM environments where security is not a concern, 0.0.0.0 can be used to allow
 REM Solr to accept connections on all network interfaces.
 REM set SOLR_JETTY_HOST=127.0.0.1
 REM Sets the network interface the Embedded ZK binds to.
-REM set SOLR_ZK_EMBEDDED_HOST=127.0.0.1
+REM set SOLR_ZOOKEEPER_SERVER_EMBEDDED_HOST=127.0.0.1

Review Comment:
   I understand that; they need to be consistent for EnvUtils to work.
   I'm discussing what the name should be (which will look a certain way when expressed as an env var vs system property).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org