You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/04/23 19:15:37 UTC

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3253: [STORM-3625] Add topo name validatiion for CLI client before connecting to nimbus

RuiLi8080 commented on a change in pull request #3253:
URL: https://github.com/apache/storm/pull/3253#discussion_r414057313



##########
File path: storm-core/src/jvm/org/apache/storm/command/KillTopology.java
##########
@@ -31,6 +32,9 @@ public static void main(String[] args) throws Exception {
 
         @SuppressWarnings("unchecked")
         final List<String> names = (List<String>) cl.get("TOPO");
+        for (String name : names) {

Review comment:
       Changed the behavior that removing invalid name from the list and throw exception if no valid name is present.
   I think this should has nothing to do with `continueOnError ` since the topology name is invalid and it makes no sense to proceed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org