You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2012/02/21 11:41:29 UTC
svn commit: r1291700 - in /subversion/trunk/subversion/tests/cmdline:
patch_tests.py svntest/actions.py
Author: philip
Date: Tue Feb 21 10:41:28 2012
New Revision: 1291700
URL: http://svn.apache.org/viewvc?rev=1291700&view=rev
Log:
Tweak a regression test so that it does not depend on APR hash order.
* subversion/tests/cmdline/patch_tests.py
(patch_property_offset): Use UnorderedOutput.
* subversion/tests/cmdline/svntest/actions.py
(run_and_verify_patch): Allow dry-run output to be in a different order
from the "wet-run" output, allow expect output to be unordered.
Modified:
subversion/trunk/subversion/tests/cmdline/patch_tests.py
subversion/trunk/subversion/tests/cmdline/svntest/actions.py
Modified: subversion/trunk/subversion/tests/cmdline/patch_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/patch_tests.py?rev=1291700&r1=1291699&r2=1291700&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/patch_tests.py (original)
+++ subversion/trunk/subversion/tests/cmdline/patch_tests.py Tue Feb 21 10:41:28 2012
@@ -2822,12 +2822,13 @@ def patch_prop_offset(sbox):
os.chdir(wc_dir)
- expected_output = [
+ # Changing two properties so output order not well defined.
+ expected_output = svntest.verify.UnorderedOutput([
' U iota\n',
'> applied hunk ## -6,6 +6,9 ## with offset -1 (prop1)\n',
'> applied hunk ## -14,11 +17,8 ## with offset 4 (prop1)\n',
'> applied hunk ## -5,6 +5,7 ## with offset -3 (prop2)\n',
- ]
+ ])
expected_disk = svntest.main.greek_state.copy()
expected_disk.tweak('iota', props = {'prop1' : prop1_content,
Modified: subversion/trunk/subversion/tests/cmdline/svntest/actions.py
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/actions.py?rev=1291700&r1=1291699&r2=1291700&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/svntest/actions.py (original)
+++ subversion/trunk/subversion/tests/cmdline/svntest/actions.py Tue Feb 21 10:41:28 2012
@@ -1217,16 +1217,11 @@ def run_and_verify_patch(dir, patch_path
raise verify.SVNUnexpectedStderr
if dry_run and out != out_dry:
- print("=============================================================")
- print("Outputs differ")
- print("'svn patch --dry-run' output:")
- for x in out_dry:
- sys.stdout.write(x)
- print("'svn patch' output:")
- for x in out:
- sys.stdout.write(x)
- print("=============================================================")
- raise main.SVNUnmatchedError
+ # APR hash order means the output order can vary, assume everything is OK
+ # if only the order changes.
+ out_dry_expected = svntest.verify.UnorderedOutput(out)
+ verify.compare_and_display_lines('dry-run patch output not as expected',
+ '', out_dry_expected, out_dry)
def missing_skip(a, b):
print("=============================================================")
@@ -1249,7 +1244,8 @@ def run_and_verify_patch(dir, patch_path
# when the expected output is a list, we want a line-by-line
# comparison to happen instead of a tree comparison
- if isinstance(output_tree, list):
+ if (isinstance(output_tree, list)
+ or isinstance(output_tree, verify.UnorderedOutput)):
verify.verify_outputs(None, out, err, output_tree, error_re_string)
output_tree = None