You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Siddhant Sangwan (Jira)" <ji...@apache.org> on 2021/08/31 11:32:00 UTC
[jira] [Updated] (HDDS-5671) ContainerBalancer#stop should prevent
the current balancing thread from interrupting itself.
[ https://issues.apache.org/jira/browse/HDDS-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddhant Sangwan updated HDDS-5671:
-----------------------------------
Summary: ContainerBalancer#stop should prevent the current balancing thread from interrupting itself. (was: ContainerBalancer#stop interrupts the balancing thread before letting it join.)
> ContainerBalancer#stop should prevent the current balancing thread from interrupting itself.
> --------------------------------------------------------------------------------------------
>
> Key: HDDS-5671
> URL: https://issues.apache.org/jira/browse/HDDS-5671
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: SCM
> Reporter: Siddhant Sangwan
> Assignee: Siddhant Sangwan
> Priority: Minor
> Labels: pull-request-available
>
> ContainerBalancer#stop interrupts the balancing thread before letting it join:
> {code:title=ContainerBalancer#stop}
> balancerRunning = false;
> currentBalancingThread.interrupt();
> currentBalancingThread.join(1000);
> {code}
> This causes:
> {quote}
> [ContainerBalancer] WARN balancer.ContainerBalancer (ContainerBalancer.java:stop(731)) - Interrupted while waiting for balancing thread to join.
> [ContainerBalancer] INFO balancer.ContainerBalancer (ContainerBalancer.java:stop(736)) - Container Balancer stopped successfully.
> {quote}
> ContainerBalancer should instead let the balancing thread joing before calling interrupt.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org