You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/06/13 07:13:14 UTC
[GitHub] zeppelin pull request #1002: ZEPPELIN-992
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1002
ZEPPELIN-992
### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Divide tests
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992
### How should this be tested?
Changed only test case
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-992
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1002
----
commit 8ef2be381fbc9e03dc54200009ae3e53332fc459
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-13T07:08:43Z
Moved Interpreter.interpret into LazyOpenInterpreterTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/1002
ZEPPELIN-992
### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Divide tests
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992
### How should this be tested?
Changed only test case
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-992
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1002
----
commit 8ef2be381fbc9e03dc54200009ae3e53332fc459
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-13T07:08:43Z
Moved Interpreter.interpret into LazyOpenInterpreterTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1002
@bzz Thanks for the guide. I'm good at selenium, thus I thought ZeppelinIT.testSparkInterpreterDependencyLoading was related to that issue. I'll look into it but do you know how to reproduce or why it occurs? I re-triggered it and passed all tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1002
The failures is related to ZEPPELIN-878
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1002: ZEPPELIN-992 Move some tests from InterpreterFa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1002: ZEPPELIN-992 Move some tests from InterpreterFactoryTe...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1002
Looks great to me and CI passes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1002: ZEPPELIN-992
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/1002
ZEPPELIN-992
### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is related to #987 a little bit.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Divide tests
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992
### How should this be tested?
Changed only test case
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-992
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1002
----
commit 8ef2be381fbc9e03dc54200009ae3e53332fc459
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-06-13T07:08:43Z
Moved Interpreter.interpret into LazyOpenInterpreterTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1002: ZEPPELIN-992
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1002
@jongyoul the CI failure I can see does not seem to be part of any existing open sub-task in [ZEPPELIN-878](https://issues.apache.org/jira/browse/ZEPPELIN-878)
```
09:02:21,815 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ZeppelinIT while testSparkInterpreterDependencyLoading
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='modal-dialog'][contains(.,'Do you want to update this interpreter and restart with new settings?')]//div[@class='modal-footer']//butt
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---