You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tooling.apache.org by sb...@apache.org on 2026/04/13 19:58:46 UTC
(tooling-trusted-releases) branch sbp updated (bd7cadaa -> 5326ecb3)
This is an automated email from the ASF dual-hosted git repository.
sbp pushed a change to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
discard bd7cadaa Remove a warning about second round recipient selection being incomplete
discard 8a1921b0 Make announcement e2e tests more stable
new 5326ecb3 Make announcement e2e tests more stable
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (bd7cadaa)
\
N -- N -- N refs/heads/sbp (5326ecb3)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
atr/get/voting.py | 3 +++
1 file changed, 3 insertions(+)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org
(tooling-trusted-releases) 01/01: Make announcement e2e tests more stable
Posted by sb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
commit 5326ecb36fa571db13faf41a583140d428b21d28
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Mon Apr 13 20:49:08 2026 +0100
Make announcement e2e tests more stable
---
tests/e2e/announce/conftest.py | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/tests/e2e/announce/conftest.py b/tests/e2e/announce/conftest.py
index c693cd0e..d74d6a56 100644
--- a/tests/e2e/announce/conftest.py
+++ b/tests/e2e/announce/conftest.py
@@ -70,6 +70,10 @@ def announce_context(browser: Browser) -> Generator[BrowserContext]:
page.wait_for_url(f"**/compose/{PROJECT_KEY}/{VERSION_KEY}")
helpers.wait_for_upload_and_tasks(page, f"/compose/{PROJECT_KEY}/{VERSION_KEY}", FILE_NAME)
+ vote_path = page.locator("#start-vote-button").get_attribute("href")
+ assert vote_path is not None
+ _wait_for_vote_start_readiness(context, vote_path)
+ helpers.visit(page, f"/compose/{PROJECT_KEY}/{VERSION_KEY}")
page.locator('a[title="Start a vote on this draft"]').click()
page.wait_for_load_state()
@@ -121,3 +125,25 @@ def _poll_for_vote_thread_link(page: Page, max_attempts: int = 30) -> None:
return
time.sleep(0.5)
page.reload()
+
+
+def _wait_for_vote_start_readiness(
+ context: BrowserContext,
+ vote_path: str,
+ timeout: float = 60,
+ stable_polls: int = 2,
+) -> None:
+ checks_path = vote_path.replace("/voting/", "/api/checks/ongoing/", 1)
+ deadline = time.monotonic() + timeout
+ stable_zero_polls = 0
+ while True:
+ ongoing = int(helpers.api_get(context.request, checks_path)["ongoing"])
+ if ongoing == 0:
+ stable_zero_polls += 1
+ if stable_zero_polls >= stable_polls:
+ return
+ else:
+ stable_zero_polls = 0
+ if time.monotonic() > deadline:
+ raise TimeoutError(f"Checks did not finish for {checks_path} within {timeout}s")
+ time.sleep(0.5)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org