You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/09/17 00:04:41 UTC
[kudu-CR] [common] small re-factoring on PartitionPruner
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17854
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
[common] small re-factoring on PartitionPruner
This changelist simplifies the signature of the
PartitionPruner::ConstructPartitionKeyRanges() method: the in-out
parameter is removed and turned into the return value.
I also moved RangeBoundsAndPartitionKeyRanges, RangeBounds, and
PartitionKeyRange structures into the private section of the
PartitionPruner class and removed default constructor declarations
for them. There is no point of declaring default constructors for
structures: the compiler creates them automatically.
This patch doesn't contain any functional changes.
Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
---
M src/kudu/common/partition_pruner.cc
M src/kudu/common/partition_pruner.h
2 files changed, 37 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17854/1
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [common] small re-factoring on PartitionPruner
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17854 )
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in RaftConsensusITest.TestSlowFollower
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Sep 2021 00:55:49 +0000
Gerrit-HasComments: No
[kudu-CR] [common] small re-factoring on PartitionPruner
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17854 )
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
[common] small re-factoring on PartitionPruner
This changelist simplifies the signature of the
PartitionPruner::ConstructPartitionKeyRanges() method: the in-out
parameter is removed and turned into the return value.
I also moved RangeBoundsAndPartitionKeyRanges, RangeBounds, and
PartitionKeyRange structures into the private section of the
PartitionPruner class and removed default constructor declarations
for them. There is no point of declaring default constructors for
structures: the compiler creates them automatically.
This patch doesn't contain any functional changes.
Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Reviewed-on: http://gerrit.cloudera.org:8080/17854
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/partition_pruner.cc
M src/kudu/common/partition_pruner.h
2 files changed, 37 insertions(+), 48 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [common] small re-factoring on PartitionPruner
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17854 )
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Sep 2021 06:38:29 +0000
Gerrit-HasComments: No
[kudu-CR] [common] small re-factoring on PartitionPruner
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17854 )
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Sep 2021 06:52:47 +0000
Gerrit-HasComments: No
[kudu-CR] [common] small re-factoring on PartitionPruner
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [common] small re-factoring on PartitionPruner
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I38c5c4809f251c8efff0de584bbbbbc03e9d952e
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>